[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 --- Comment #11 from bastimeyer...@gmail.com --- (In reply to Vlad Zahorodnii from comment #9) > Hmm, we received confirmation from other people that this issue is fixed in > 5.23. Please make sure that it's not a packaging issue. Yes, apologies, my mistake. Looks like it's indeed fixed now. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Version Fixed In||5.23 --- Comment #10 from Nate Graham --- Indeed. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 --- Comment #9 from Vlad Zahorodnii --- Hmm, we received confirmation from other people that this issue is fixed in 5.23. Please make sure that it's not a packaging issue. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 --- Comment #8 from bastimeyer...@gmail.com --- The issue is still present on 5.23, and I still have to patch kwin to be able to use the desktop grid effect on my multi-monitor setup (been doing this now for 2 1/2 years), otherwise it's completely unusable. Same patch as mentioned above, just rebased onto 5.23: https://github.com/bastimeyer/arch-packages/blob/e39a0633c4916f2302323c4fc6b3e500d1745429/kwin/desktopgrid-overlaying-tile-fix.patch -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 Mahe changed: What|Removed |Added CC||m...@fsfe.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 --- Comment #7 from Vlad Zahorodnii --- Some windows will be incorrectly rendered. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 Santiago Podestá changed: What|Removed |Added Version|5.14.1 |5.19.5 CC||santiagol...@gmail.com --- Comment #6 from Santiago Podestá --- (In reply to Vlad Zahorodnii from comment #4) > I think it's not a good idea to unset PAINT_SCREEN_TRANSFORMED because KWin > checks that flag when deciding what method to use for clipping windows. What problems would that bring? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 Vlad Zagorodniy changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #5 from Vlad Zagorodniy --- The problem seems to be that SceneOpenGL::Window::beginRenderWindow clips windows incorrectly, it doesn't take into account transformations applied to the window. Though if we fix that clipping code, I fear that we'll break the slide effect. Quite delicate situation... -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 --- Comment #4 from Vlad Zagorodniy --- I think it's not a good idea to unset PAINT_SCREEN_TRANSFORMED because KWin checks that flag when deciding what method to use for clipping windows. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 --- Comment #3 from bastimeyer...@gmail.com --- I think I have found a fix for this issue. In the DesktopGridEffect's prePaintScreen method, two additional bits are set on the ScreenPrePaintData mask: PAINT_SCREEN_TRANSFORMED and PAINT_SCREEN_BACKGROUND_FIRST https://github.com/KDE/kwin/blob/v5.14.90/effects/desktopgrid/desktopgrid.cpp#L164 According to the scene header file, the whole screen will be painted if PAINT_SCREEN_TRANSFORMED is set. PAINT_SCREEN_REGION on the other hand will only paint a region of the screen. https://github.com/KDE/kwin/blob/v5.14.90/scene.h#L116-L120 So in order to fix the issue of the overlaying tiles, I tried to replace PAINT_SCREEN_TRANSFORMED with PAINT_SCREEN_REGION and rebuilt my disto's kwin package with this change applied. This did indeed fix it, but another issue I could observe was a bit of occasional jittering on the borders of each tile after the end of the animation. Because of this, I changed the bitmask again and made it so, that PAINT_SCREEN_TRANSFORMED gets set at the end of the animation, while PAINT_SCREEN_REGION gets set during the animation. This fixed the jittering and everything seems to be working well now. But since I don't know anything about the internals of KWin and since I'm also not a c++ dev, I don't want to submit a patch and would instead kindly ask for somebody else to properly take a look at this, so that this annoying bug can finally be fixed. Thanks! Here is my diff: https://gist.githubusercontent.com/bastimeyer/81c60699e5f5e762beb01a4bfeff1700/raw/04a2ab784f05f9f3cec522f4ac2a470e9cc803ac/desktopgrid-overlaying-tiles-fix.patch -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 351687] Desktop grid expands onto other screens during zoom-in animation
https://bugs.kde.org/show_bug.cgi?id=351687 bastimeyer...@gmail.com changed: What|Removed |Added Summary|Desktop grid on two |Desktop grid expands onto |monitors looks a little |other screens during |funny on exit |zoom-in animation -- You are receiving this mail because: You are watching all bug changes.
