[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376848

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=391315

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=376848

Eike Hein  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/db42961ad4d8c87
   ||877e549ce63f81b9f2bf7b0b3
 Resolution|--- |FIXED

--- Comment #14 from Eike Hein  ---
Git commit db42961ad4d8c87877e549ce63f81b9f2bf7b0b3 by Eike Hein.
Committed on 05/02/2018 at 15:08.
Pushed by hein into branch 'Plasma/5.12'.

Improve preview thumbnail quality

Summary:
This patch does two things:

* Instead of giving the KAbstractViewAdapter the actual icon size,
  we overprovision by giving it the size times two. This is because
  while we're deriving the grid view cell size from the icon size
  setting, it's not the actual size the thumbnails will be displayed
  at. Our IconItem is sized to almost fill the cell, and for image
  sources with non-square aspect ratios IconItem doesn't scale to
  the next icon size.

* We set IconItem to do smooth scaling.

While this results in lovely visual fidelity, I the performance
impact is a concern. We're requesting twice as large thumbnails
now, and we're doing more scaling work. However, thumbnail
generation is async and doesn't slow down listing. There's also
the possibility IconItem::smooth could have general performance
impact unless things are smart enough not to scale when not
necessary, which is hopefully the case.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10223

M  +2-0containments/desktop/package/contents/ui/FolderItemDelegate.qml
M  +1-1containments/desktop/package/contents/ui/FolderView.qml
M  +3-0containments/desktop/plugins/folder/foldermodel.cpp

https://commits.kde.org/plasma-desktop/db42961ad4d8c87877e549ce63f81b9f2bf7b0b3

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=376848

--- Comment #13 from Eike Hein  ---
Sorry, botched copy'n'paste. Correct link: https://phabricator.kde.org/D10223

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=376848

--- Comment #12 from Eike Hein  ---
Patch under review: https://phabricator.kde.or

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=376848

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=376848

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #11 from Alexander Mentyu  ---
Confirming in:

Netrunner Rolling
Plasma: 5.11.4
Apps: 17.08.3
Frameworks: 5.40.0
Qt: 5.9.3
Kernel: 4.14.3-1-MANJARO

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Todor Gyumyushev]

https://bugs.kde.org/show_bug.cgi?id=376848

Todor Gyumyushev  changed:

   What|Removed |Added

 CC||yo...@developer.bg

--- Comment #10 from Todor Gyumyushev  ---
I have the issue too - all previews/thumbnails of image files regardless of
their size is pixelated. I'm using folder layout. Maybe is best to have option
for user to choose the preview quality.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376848

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Gerhard Dittes]

https://bugs.kde.org/show_bug.cgi?id=376848

--- Comment #9 from Gerhard Dittes  ---
Hi,

any news on this?  It would be very nice to have this fixed/improved for the
upcoming version of Plasma LTS...

I see this issue every time I look at my desktop and it really feels so
obviously buggy (or amateurishly)...

Please, please increase priority! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376848

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376848

libook...@gmail.com changed:

   What|Removed |Added

 CC||libook...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Gerhard Dittes]

https://bugs.kde.org/show_bug.cgi?id=376848

Gerhard Dittes  changed:

   What|Removed |Added

 CC||g-...@web.de

--- Comment #8 from Gerhard Dittes  ---
Hi, I can confirm this behavior (e.g. on "current KDE Neon Dev Stable", newest
plasma-framework version).

Seems that Kai Uwe already found the right location for fixing this. @Kai Uwe:
Do you have time to take care of this? ;-)

Anyway, this bug should be marked as "CONFIRMED". Furthermore, it should really
get attention:

Desktop icons are such an important thing (and [as everybody might know] as of
plasma 5.10 they are turned on by default (again)).

Pixelated previews really look ugly and make the whole Desktop appear kind of
buggy (imho)...

Thx for taking care...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[lctrgk]

https://bugs.kde.org/show_bug.cgi?id=376848

lctrgk  changed:

   What|Removed |Added

 CC||lct...@outlook.com

--- Comment #7 from lctrgk  ---
Hi, i've always noticed this too and when it's not a big deal it's kind of
annoying. I'm using plasma 5 since the version 5.5 and this problem has always
been there. Thumbnails on the desktop view looks blocky (which is not
necessarily the same as pixelated). This doesn't happen to icons, for example
if you create an access to a program from the launcher (for axample a .desktop)
it'll be smooth regardless of if it's a vector or raster image. However if you
put that same image on the desktop view alongside the .desktop file the
difference is noticeable. I think it has something to do with the aspect ratio
of the image because it the image is 1:1 it looks a lot better.

I think this should be investigated in a similar way this other bug was fixed:
https://bugs.kde.org/show_bug.cgi?id=355592

I noticed the same thing can happen on other places aside from the desktop
view, for example the user avatar on the default launcher or the user selection
plasmoid.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=376848

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #6 from Kai Uwe Broulik  ---
Setting smooth to true in the IconItem should help but the item view adapter
needs to be adjusted for the new non-square area the icon can have - so far it
only requests e.g. 64x64 previews leading to small thumbs being scaled up.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=376848

Martin Klapetek  changed:

   What|Removed |Added

 CC||mklape...@kde.org

--- Comment #5 from Martin Klapetek  ---
Created attachment 104924
  --> https://bugs.kde.org/attachment.cgi?id=104924=edit
Screenshot

I can confirm the pixelation in previews, see
the attached screenshot (compare with the sharp
icons around). This is the case with all previews
as far as I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Tony]

https://bugs.kde.org/show_bug.cgi?id=376848

--- Comment #4 from Tony  ---
(In reply to Marco Martin from comment #1)
> pixelated thumbnails?

Yes. Thumbnails of images on the desktop are pixelated even if you set the
icons size to max.

I also notice it happens for some video files with ".avi" extension.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376848

Christoph Feck  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |UNCONFIRMED

--- Comment #3 from Christoph Feck  ---
There are two thumbnails at the right-hand side (inside the black area), which
really look pixelated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=376848

Eike Hein  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #2 from Eike Hein  ---
What's the issue exactly? I don't see a problem on the screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376848] Folder View not rendering images correctly.

[Marco Martin]

https://bugs.kde.org/show_bug.cgi?id=376848

Marco Martin  changed:

   What|Removed |Added

 CC||notm...@gmail.com,
   ||plasma-b...@kde.org
  Component|Desktop Containment |Folder
   Assignee|se...@kde.org   |h...@kde.org

--- Comment #1 from Marco Martin  ---
pixelated thumbnails?

-- 
You are receiving this mail because:
You are watching all bug changes.