https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #35 from Carl Love ---
Updated all of the patches to make sure everything is consistent.
All of the requested changes were made. Reran the regression test. No
regressions found. Will commit the attached patches.
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130690|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #131014|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130631|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130632|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130630|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #29 from Carl Love ---
comment 24
There is a comment in the caller of function calculate_prefix_EA() that R must
be set to 0 for word instruction. But that is a bit dangerous. So, made sure
*R gets set to 0 in the function for word
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #28 from Carl Love ---
oops
effect on determining an unknown instruction.
3) Changed prefixInst to prefix and fixed up one conflict due to the name
change.
4) Fixed comment and spelling error.
Will update patch once I get
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #27 from Carl Love ---
comment 25
1) return type for dis_nop_prefix
- as requested changed to using an enum for the return value.
2) #define ENABLE_PREFIX_CHECK
- This was added as an extra check during development. It was used
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #26 from Julian Seward ---
(In reply to Carl Love from comment #13)
> Created attachment 130630 [details]
> Add check for isa 3.1 support
Ok to land.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #25 from Julian Seward ---
(In reply to Carl Love from comment #14)
> Created attachment 130631 [details]
> Instruction prefix support
ok to land provided at least that the dis_nop_prefix return type is fixed
properly.
> + int ret;
>
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #24 from Julian Seward ---
(In reply to Carl Love from comment #15)
> Created attachment 130632 [details]
> Add prefixed support for the following word
ok to land but please at least consider the following:
> +/* Prefix instsruction
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #23 from Julian Seward ---
(In reply to Carl Love from comment #21)
> Created attachment 131014 [details]
> Test suite foundation
ok to land.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #22 from Julian Seward ---
(In reply to Carl Love from comment #18)
> Created attachment 130690 [details]
> Testsuite load store word instructions
Ok to land.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130689|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #20 from Carl Love ---
Created bugzilla for second set of patches.
https://bugs.kde.org/show_bug.cgi?id=425232
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #19 from Carl Love ---
The testsuite has been updated to address the concerns with the previous patch.
The C code that was in the isa_3_1_helpers.h file has been put into a new file
test_isa_3_1_common.c.
The license for the test files
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #18 from Carl Love ---
Created attachment 130690
--> https://bugs.kde.org/attachment.cgi?id=130690=edit
Testsuite load store word instructions
Add tests for the load store word instructions.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130174|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #16 from Carl Love ---
I have uploaded the latest version of the three Valgrind ISA 3.1 support
patches.
A small error was found in the patch for "Add check for isa 3.1 support". The
original line in coregrind/m_initimg/initimg-linux.c,
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130176|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130175|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
Attachment #130173|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #12 from Will Schmidt ---
(In reply to Julian Seward from comment #11)
> (In reply to Carl Love from comment #5)
> > Created attachment 130176 [details]
> > Initial load and store instruction tests
> >
> >
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #11 from Julian Seward ---
(In reply to Carl Love from comment #5)
> Created attachment 130176 [details]
> Initial load and store instruction tests
>
> 0004-Initial-ISA-3.1-instruction-tests.patch
>
> Testsuite for new instructions
diff
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #9 from Julian Seward ---
(In reply to Carl Love from comment #3)
> Created attachment 130174 [details]
> Adds the support for prefix instructions
>
> 0002-ISA-3.1-Instruction-Prefix-Support.patch
>
> Adds the support for prefix
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #10 from Julian Seward ---
(In reply to Carl Love from comment #4)
> Created attachment 130175 [details]
> Add prefixed support for the following word
>
> 0003-ISA-3.1-Add-prefixed-support-for-the-following-word-.patch
>
> Add prefixed
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #8 from Julian Seward ---
(In reply to Carl Love from comment #3)
> Created attachment 130174 [details]
> Adds the support for prefix instructions
>
> 0002-ISA-3.1-Instruction-Prefix-Support.patch
>
> Adds the support for prefix
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #7 from Julian Seward ---
(In reply to Carl Love from comment #2)
> Created attachment 130173 [details]
> Add check for isa 3.1 support
>
> 0001-Add-check-for-isa-3.1-support.patch
>
> Adds base support for detecting ISA 3.1
Looks OK to
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #6 from Carl Love ---
This bugzilla covers the first four patches of the ISA 3.1 support for PPC.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #5 from Carl Love ---
Created attachment 130176
--> https://bugs.kde.org/attachment.cgi?id=130176=edit
Initial load and store instruction tests
0004-Initial-ISA-3.1-instruction-tests.patch
Testsuite for new instructions
--
You are
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #4 from Carl Love ---
Created attachment 130175
--> https://bugs.kde.org/attachment.cgi?id=130175=edit
Add prefixed support for the following word
0003-ISA-3.1-Add-prefixed-support-for-the-following-word-.patch
Add prefixed support for
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #3 from Carl Love ---
Created attachment 130174
--> https://bugs.kde.org/attachment.cgi?id=130174=edit
Adds the support for prefix instructions
0002-ISA-3.1-Instruction-Prefix-Support.patch
Adds the support for prefix instructions
--
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #2 from Carl Love ---
Created attachment 130173
--> https://bugs.kde.org/attachment.cgi?id=130173=edit
Add check for isa 3.1 support
0001-Add-check-for-isa-3.1-support.patch
Adds base support for detecting ISA 3.1
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=423195
Carl Love changed:
What|Removed |Added
CC||will_schm...@vnet.ibm.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #1 from Carl Love ---
Posted first 4 of about 36 patches for review.
--
You are receiving this mail because:
You are watching all bug changes.
38 matches
Mail list logo