[Discover] [Bug 391792] KNS screenshots have 1:1 aspect ratios and tiny thumbnails

2018-03-16 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=391792

Dan Jensen  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Dan Jensen  ---
As the main issue reported of the 1:1 previews is now fixed, i'll close the
bug. The second issue also needs sorting, but as it's a sort of notabug type
situation it needs another thing to be able to track it anyway (or we just need
to discuss that and make a choice).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391792] KNS screenshots have 1:1 aspect ratios and tiny thumbnails

2018-03-13 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=391792

Dan Jensen  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=391107

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391792] KNS screenshots have 1:1 aspect ratios and tiny thumbnails

2018-03-13 Thread Dan Jensen
https://bugs.kde.org/show_bug.cgi?id=391792

Dan Jensen  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||ad...@leinir.dk
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Dan Jensen  ---
What we've got here are two different issues. The last one first:

It seems that the KDE Store is providing something a little odd when you
request the previews. The specific example shown here is Arc, and the thumbnail
requested via OCS is
https://cn.pling.com/cache/770x540/img/f/3/6/9/090ea1ab91bedab023d852189e47e2f4d475.png
What is suggested in the URL is that it should be a 770x540 image, but what is
actually returned is 770x770, and just plain incorrect, both technically and
semantically. So, I'll forward this bug to the Store team, see if they can sort
that for us :)

For the second one, it seems as though SmallPreview is used (which is indeed
thumbnails, but they're supposed to be kind of small, and what's in Discover
is, quite distinctly, not small thumbnails...) So, don't use the intentionally
icon-sized thumbnails when what you want is a medium-sized preview (use the
full size previews in that list instead - i realise that having a middle point
would be useful and whatnot, but such an option does not exist in OCS). In
other words: The code was correct for the original design, when the preview
images on application pages were small, but as the design has changed and
requires large previews, that is no longer the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391792] KNS screenshots have 1:1 aspect ratios and tiny thumbnails

2018-03-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=391792

--- Comment #1 from Nate Graham  ---
Created attachment 111357
  --> https://bugs.kde.org/attachment.cgi?id=111357&action=edit
screenshots forced to 1:1 aspect ratio

-- 
You are receiving this mail because:
You are watching all bug changes.