[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 Nate Graham changed: What|Removed |Added Version Fixed In||5.51 Latest Commit||https://commits.kde.org/bal ||oo/2452ce28193a7cf4843a8f61 ||7f3fe29c6643fd96 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #5 from Nate Graham --- Git commit 2452ce28193a7cf4843a8f617f3fe29c6643fd96 by Nathaniel Graham. Committed on 30/09/2018 at 01:17. Pushed by ngraham into branch 'master'. [Balooctl] remove directory parent check Summary: `balooctl add includeFolders/excludeFolders` was checking for parent directories before allowing the user to add a subdirectory. This is unnecessary since Baloo itself supports the logic of (for example) excluding `~/foo` but including `~/foo/bar`. Removing the check solves the problem and fixes 396535. FIXED-IN: 5.51 Test Plan: ``` mkdir ~/test1 ~/test2 ~/test1-test ~/test1-test/foo balooctl config add excludeFolders ~/test1 balooctl config add excludeFolders ~/test2 balooctl config add excludeFolders ~/test1-test balooctl config add includeFolders ~/test1-test/foo ``` If it worked, you don't get any errors. Reviewers: #baloo, #dolphin, bruns, #frameworks, cfeck Reviewed By: #baloo, bruns Subscribers: smithjd, anthonyfieroni, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D15583 M +0-14 src/tools/balooctl/configcommand.cpp https://commits.kde.org/baloo/2452ce28193a7cf4843a8f617f3fe29c6643fd96 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 --- Comment #4 from Nate Graham --- No response from James; I have submitted the patch at https://phabricator.kde.org/D15583 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 --- Comment #3 from Christoph Feck --- Thanks James for the patch! Could you please add it to https://phabricator.kde.org/differential/diff/create/ so that developers can review it? We have more information about Phabricator at https://community.kde.org/Infrastructure/Phabricator -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 --- Comment #2 from James Ausmus --- Created attachment 114556 --> https://bugs.kde.org/attachment.cgi?id=114556=edit Fixes issue by appending path separator to parent dir check -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 James Ausmus changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|baloo-bugs-n...@kde.org |james.aus...@gmail.com Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 James Ausmus changed: What|Removed |Added CC||james.aus...@gmail.com --- Comment #1 from James Ausmus --- It looks like the issue isn't related to the hyphen, but rather that '~/test1-test' doesn't get past the "path.startsWith(folder)" check when folder is '~/test1' - proposed patch momentarily -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 396535] Balooctl seems to assume folders with hyphens in name are subfolders
https://bugs.kde.org/show_bug.cgi?id=396535 Nate Graham changed: What|Removed |Added Keywords||junior-jobs CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
