D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric added a comment. @apol I did update the commit body to explain why. For the text I used https://regex101.com with the icon in the commit body and printing the variables of CMAKE_MATCH_1 and CMAKE_MATCH_2 Let me know if you agree with this to land the patch, this is

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

patrickelectric updated this revision to Diff 73927. patrickelectric added a comment. Add commit body REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26751?vs=73830=73927 BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

patrickelectric added a comment. Hi @cgiboudeaux, thanks for the explanation, I'll take a look and get back here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava, cgiboudeaux, bcooksley Cc: bcooksley,

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

cgiboudeaux added a comment. In D26752#597149 , @patrickelectric wrote: > Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ? > > In #kirogi

D26749: WIP: Support NDK r20 and Qt 5.14

vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a