Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-23 Thread Yury G. Kudryashov
Rex Dieter wrote: Yury G. Kudryashov wrote: I don't think that adding REQUIRED is the right thing to do. Probably, if(NOT TARGET nepomukcore) if(KdepimLibs_FIND_REQUIRED) find_package(NepomukCore REQUIRED NO_MODULE) else() find_package(NepomukCore NO_MODULE)

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-22 Thread Rex Dieter
/2012 at 01:11. Pushed by bcooksley into branch 'master'. Interim hack to make everything which depends on kdepimlibs build again. A proper solution is needed from the CMake folks, but I don't see consensus on that. FWIW, I think the change you comitted is almost the right fix, you forgot

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Andreas Pakulat
Hi, On Thu, Dec 20, 2012 at 1:11 AM, Ben Cooksley bcooks...@kde.org wrote: Git commit f9ea1c7b4fb351a4da16b386c23f15d6c109728a by Ben Cooksley. Committed on 20/12/2012 at 01:11. Pushed by bcooksley into branch 'master'. Interim hack to make everything which depends on kdepimlibs build again

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Ben Cooksley
'. Interim hack to make everything which depends on kdepimlibs build again. A proper solution is needed from the CMake folks, but I don't see consensus on that. FWIW, I think the change you comitted is almost the right fix, you forgot a REQUIRED there to ensure that finding kdepimlibs fails

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Andreas Pakulat
. Committed on 20/12/2012 at 01:11. Pushed by bcooksley into branch 'master'. Interim hack to make everything which depends on kdepimlibs build again. A proper solution is needed from the CMake folks, but I don't see consensus on that. FWIW, I think the change you comitted is almost the right fix, you

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Yury G. Kudryashov
by bcooksley into branch 'master'. Interim hack to make everything which depends on kdepimlibs build again. A proper solution is needed from the CMake folks, but I don't see consensus on that. FWIW, I think the change you comitted is almost the right fix, you forgot a REQUIRED there to ensure

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Christophe Giboudeaux
f9ea1c7b4fb351a4da16b386c23f15d6c109728a by Ben Cooksley. Committed on 20/12/2012 at 01:11. Pushed by bcooksley into branch 'master'. Interim hack to make everything which depends on kdepimlibs build again. A proper solution is needed from the CMake folks, but I don't see consensus on that. FWIW, I think

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Andreas Pakulat
Hi, On Thu, Dec 20, 2012 at 2:47 PM, Christophe Giboudeaux cgiboude...@gmx.com wrote: On Thursday 20 December 2012 14:12:17 Yury G. Kudryashov wrote: Ben Cooksley wrote: On Thu, Dec 20, 2012 at 9:02 PM, Andreas Pakulat ap...@gmx.de wrote: nepomuk is not found. If kdepimlibs libraries

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Alexander Neundorf
On Thursday 20 December 2012, Andreas Pakulat wrote: Hi, On Thu, Dec 20, 2012 at 2:47 PM, Christophe Giboudeaux cgiboude...@gmx.com wrote: On Thursday 20 December 2012 14:12:17 Yury G. Kudryashov wrote: Ben Cooksley wrote: On Thu, Dec 20, 2012 at 9:02 PM, Andreas Pakulat

Re: [kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-20 Thread Yury G. Kudryashov
Andreas Pakulat wrote: Hi, On Thu, Dec 20, 2012 at 2:47 PM, Christophe Giboudeaux cgiboude...@gmx.com wrote: On Thursday 20 December 2012 14:12:17 Yury G. Kudryashov wrote: I don't think that adding REQUIRED is the right thing to do. Probably, if(NOT TARGET nepomukcore)

[kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.

2012-12-19 Thread Ben Cooksley
Git commit f9ea1c7b4fb351a4da16b386c23f15d6c109728a by Ben Cooksley. Committed on 20/12/2012 at 01:11. Pushed by bcooksley into branch 'master'. Interim hack to make everything which depends on kdepimlibs build again. A proper solution is needed from the CMake folks, but I don't see consensus