Re: Review Request 108954: Fix FindLibUSB1

2013-03-09 Thread Alexander Neundorf
On Friday 08 March 2013, Yury G. Kudryashov wrote: В письме от 8 марта 2013 22:31:52 пользователь Alexander Neundorf написал: On Friday 08 March 2013, Yury G. Kudryashov wrote: There was no FindLibUSB1.cmake in kdelibs. Do we mention source incompatibilities with old unreleased ECM

Re: Review Request 108954: Fix FindLibUSB1

2013-03-08 Thread Alexander Neundorf
On Friday 15 February 2013, Alexander Neundorf wrote: On Friday 15 February 2013, Commit Hook wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108954/#review27490

Re: Review Request 108954: Fix FindLibUSB1

2013-03-08 Thread Yury G. Kudryashov
the renaming here: http://techbase.kde.org/Development/ECM_SourceIncompatChanges just so you don't forget, pleas update the wiki page with the source incompatible changes. There was no FindLibUSB1.cmake in kdelibs. Do we mention source incompatibilities with old unreleased ECM versions? -- Yury G

Re: Review Request 108954: Fix FindLibUSB1

2013-03-08 Thread Alexander Neundorf
. Kudryashov to branch master. So please document the renaming here: http://techbase.kde.org/Development/ECM_SourceIncompatChanges just so you don't forget, pleas update the wiki page with the source incompatible changes. There was no FindLibUSB1.cmake in kdelibs. Do we mention

Re: Review Request 108954: Fix FindLibUSB1

2013-03-08 Thread Yury G. Kudryashov
В письме от 8 марта 2013 22:31:52 пользователь Alexander Neundorf написал: On Friday 08 March 2013, Yury G. Kudryashov wrote: There was no FindLibUSB1.cmake in kdelibs. Do we mention source incompatibilities with old unreleased ECM versions? Doesn't it replace FindUSB.cmake ? libusb-0.1

Re: Review Request 108954: Fix FindLibUSB1

2013-02-15 Thread Commit Hook
/r/108954/ --- (Updated Feb. 14, 2013, 9:44 a.m.) Review request for Build System. Description --- Fix FindLibUSB1 - set properties on LibUSB1, not USB1 - use LibUSB1_ prefix, not LIBUSB1_ Do we care about

Re: Review Request 108954: Fix FindLibUSB1

2013-02-15 Thread Alexander Neundorf
On Thursday 14 February 2013, Yury Georgievich Kudryashov wrote: On Feb. 14, 2013, 6:12 p.m., Alexander Neundorf wrote: As long as e-c-m is not released yet, there is still time for source incompatible changes. But please list them here:

Re: Review Request 108954: Fix FindLibUSB1

2013-02-15 Thread Stephen Kelly
Alexander Neundorf wrote: On Thursday 14 February 2013, Yury Georgievich Kudryashov wrote: On Feb. 14, 2013, 6:12 p.m., Alexander Neundorf wrote: As long as e-c-m is not released yet, there is still time for source incompatible changes. But please list them here:

Re: Review Request 108954: Fix FindLibUSB1

2013-02-15 Thread Alexander Neundorf
On Friday 15 February 2013, Commit Hook wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108954/#review27490 --- This

Review Request 108954: Fix FindLibUSB1

2013-02-14 Thread Yury Georgievich Kudryashov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108954/ --- Review request for Build System. Description --- Fix FindLibUSB1

Re: Review Request 108954: Fix FindLibUSB1

2013-02-14 Thread Alexander Neundorf
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108954/ --- (Updated Feb. 14, 2013, 9:44 a.m.) Review request for Build System. Description --- Fix FindLibUSB1 - set properties on LibUSB1

Re: Review Request 108954: Fix FindLibUSB1

2013-02-14 Thread Yury Georgievich Kudryashov
/ --- (Updated Feb. 14, 2013, 9:44 a.m.) Review request for Build System. Description --- Fix FindLibUSB1 - set properties on LibUSB1, not USB1 - use LibUSB1_ prefix, not LIBUSB1_ Do we care about compatibility? If yes, we should set

FindLibUSB1

2011-09-18 Thread Yury G. Kudryashov
Hi! I think that presense of FindLibUSB1.cmake will slightly simplify transition from libusb-0.1 to libusb-1.0. Review the attached file, please. -- Yury G. Kudryashov, mailto: ur...@mccme.ru# - Try to find the libusb-1.0 library # Once done this defines # # LIBUSB1_FOUND - system has libusb

Re: FindLibUSB1

2011-09-18 Thread Alexander Neundorf
On Sunday, September 18, 2011 10:59:25 AM Yury G. Kudryashov wrote: Hi! I think that presense of FindLibUSB1.cmake will slightly simplify transition from libusb-0.1 to libusb-1.0. Review the attached file, please. Do we still need support for the older libusb version actually ? Alex

Re: FindLibUSB1

2011-09-18 Thread Yury G. Kudryashov
Alexander Neundorf wrote: On Sunday, September 18, 2011 10:59:25 AM Yury G. Kudryashov wrote: Hi! I think that presense of FindLibUSB1.cmake will slightly simplify transition from libusb-0.1 to libusb-1.0. Review the attached file, please. Do we still need support for the older libusb

Re: FindLibUSB1

2011-09-18 Thread Yury G. Kudryashov
Yury G. Kudryashov wrote: Alexander Neundorf wrote: On Sunday, September 18, 2011 10:59:25 AM Yury G. Kudryashov wrote: Hi! I think that presense of FindLibUSB1.cmake will slightly simplify transition from libusb-0.1 to libusb-1.0. Review the attached file, please. Do we still need

Re: FindLibUSB1

2011-09-18 Thread Raphael Kubo da Costa
Yury G. Kudryashov urkud.ur...@gmail.com writes: I don't know how to search for KDE code using FindUSB.cmake. lxr.kde.org - general search works if you search for, say, find_library(USB). ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org