Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-26 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/#review80860 --- Ship it! I'll take it. FTR the best solution would probably

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-26 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/ --- (Updated May 26, 2015, 6:51 p.m.) Status -- This change has been

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/#review80804 --- Linking against the QtCore target should bring in any flags

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-25 Thread Hrvoje Senjan
On May 25, 2015, 12:34 p.m., Alex Merry wrote: Linking against the QtCore target should bring in any flags necessary to make that link succeed. If it doesn't, that's a problem with Qt's CMake targets. Thiago's email to the list suggested that had been resolved in the 5.4.2

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-25 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/ --- (Updated May 25, 2015, 6:08 p.m.) Review request for Build System,

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-22 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/#review80723 --- Like Thiago already suggested on kde-core-devel, this might

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/#review80716 --- I'm unsure this is what you need, builds fine here... -

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Hrvoje Senjan
On May 22, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: I'm unsure this is what you need, builds fine here... Do you have the mentioned commit? It's in latest 5.4.2 5.4 branches, but *not* 5.5 - Hrvoje --- This is an automatically

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Aleix Pol Gonzalez
On May 22, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: I'm unsure this is what you need, builds fine here... Hrvoje Senjan wrote: Do you have the mentioned commit? It's in latest 5.4.2 5.4 branches, but *not* 5.5 Ah, sorry, I have 5.5. Anyway, are you sure this is needed?

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Hrvoje Senjan
On May 22, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: I'm unsure this is what you need, builds fine here... Hrvoje Senjan wrote: Do you have the mentioned commit? It's in latest 5.4.2 5.4 branches, but *not* 5.5 Aleix Pol Gonzalez wrote: Ah, sorry, I have 5.5. Anyway,

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Thiago Macieira
On Thursday 21 May 2015 23:11:22 Aleix Pol Gonzalez wrote: On May 22, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: I'm unsure this is what you need, builds fine here... Hrvoje Senjan wrote: Do you have the mentioned commit? It's in latest 5.4.2 5.4 branches, but *not* 5.5

Re: Review Request 123874: Fix build with Qt = 5.4.2

2015-05-21 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123874/ --- (Updated May 22, 2015, 6:45 a.m.) Review request for Build System,