Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-11-04 Thread Kevin Ottens
On Oct. 30, 2013, 10:47 a.m., David Faure wrote: Looks good to me (apart from the expired pastebin links in the initial description). I can't Ship it because I'm not a cmake guru/maintainer though. Same here, looks OK, but I'd like Alex or Stephen to give it the ship it. - Kevin

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-29 Thread Aleix Pol Gonzalez
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 32 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32 I recommend not putting this in the API of the function, and instead users should use

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:32 a.m.) Review request for Build System, KDE

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42415 --- Thanks for working on this! modules/ECMGenerateHeaders.cmake

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 29 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29 This variable shouldn't be needed at all. Aleix Pol Gonzalez wrote: Variable? Or argument? Why? Stephen

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 9:35 a.m.) Review request for Build System, KDE

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42396 --- The install dir is still in the documentation and in the

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 26, 2013, 10:56 a.m.) Review request for Build System, KDE

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 24, 2013, 1:40 p.m.) Review request for Build System, KDE

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 --- modules/ECMGenerateHeaders.cmake

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Aleix Pol Gonzalez
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 29 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29 This variable shouldn't be needed at all. Variable? Or argument? Why? On Oct. 24, 2013, 1:54 p.m., Stephen

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Stephen Kelly
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 11 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line11 I really think the answers to my questions here need to be found first:

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-24 Thread Alexander Neundorf
On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: modules/ECMGenerateHeaders.cmake, line 29 http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29 This variable shouldn't be needed at all. Aleix Pol Gonzalez wrote: Variable? Or argument? Why? Stephen

Review Request 113406: Add a macro to automatically generate forward headers

2013-10-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- Review request for Build System, KDE Frameworks and Stephen Kelly.

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-23 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42250 --- IMO the documentation could be improved. It should mention the