Review Request 119339: Copy updates for PyQt4 build system changes from kdelilbs to e-c-m

2014-07-17 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119339/ --- Review request for Extra Cmake Modules, Alex Merry, Luca Beltrame, Raphael

Re: Review Request 119339: Copy updates for PyQt4 build system changes from kdelilbs to e-c-m

2014-07-17 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119339/#review62588 --- I don't have any objections with forward-porting the kdelibs

Re: Review Request 119339: Copy updates for PyQt4 build system changes from kdelilbs to e-c-m

2014-07-17 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119339/#review62589 --- Ship it! I second rakuco's comment. Go ahead, but bear in

Re: Review Request 119339: Copy updates for PyQt4 build system changes from kdelilbs to e-c-m

2014-07-17 Thread Scott Kitterman
On July 17, 2014, 3:04 p.m., Luca Beltrame wrote: I second rakuco's comment. Go ahead, but bear in mind this is not part of ECM, AFAICS. Will do. This is mostly so that if it's not redone from scratch, whoever does it will start from the latest. - Scott

Re: Review Request 119339: Copy updates for PyQt4 build system changes from kdelilbs to e-c-m

2014-07-17 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119339/ --- (Updated July 17, 2014, 3:18 p.m.) Status -- This change has been