D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-06-16 Thread Friedrich W. H. Kossebau
kossebau added a comment. Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM

D21313: Create specific directory for Qt logging categories file

2019-06-16 Thread Ben Cooksley
bcooksley added a comment. The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there). The CI system on the other hand uses it's own tooling

D21313: Create specific directory for Qt logging categories file

2019-06-16 Thread Volker Krause
vkrause added a comment. In D21313#480401 , @kossebau wrote: > @apol @vkrause Perhaps something to check wit the CI or in general with the ECM Android toolchain to make sure the ECM of the host and the target are not accidentally mixed or both