Re: pthread configure problem in kdelibs trunk

On Sunday 09 April 2006 16:31, Volker Krause wrote: the test for pthread_getattr_np() fails due to a missing '-pthread' in the linker flags (at least for cartman and myself). This prevents the compilation of kjs. The removal of those tests has fixed the problem as well, the corresponding

[PATCH] makekdewidgets macro

Hi, the attached patch contains a cmake macro for the makekdewidgets code generation tool. Currently there are cutsom commands in at least three diffrent places (libs, pim, edu) to handle this. Ok to commit? regards Volker Index: FindKDE4Internal.cmake

make clean and .la files

Hi, I get a FILE INSTALL cannot find file foo.la to install. on 'make install' in case I did a 'make clean' before and cmake hasn't run in between. If I understand correctly the problem is the following: The .la file are generated by cmake (ie. while evaluating the kde4_install_libtool_file

Re: KDE/kdelibs/cmake/modules

Laurent Montel wrote: On Tuesday 01 August 2006 20:22, David Faure wrote: On Monday 31 July 2006 09:41, Laurent Montel wrote: SVN commit 568125 by mlaurent: Fix pb when we relauch ccmake -D... ../ LIB_* variable was not changed M +1 -1 FindKDE4Internal.cmake ---

Re: KDE/kdelibs/cmake/modules

On Thursday 03 August 2006 10:17, Laurent Montel wrote: On Tuesday 01 August 2006 20:22, David Faure wrote: What do you think about this patch ? I readd as for old build system a libsuffix Index: FindKDE4Internal.cmake === ---

Re: KDE/kdelibs/cmake/modules

On Tuesday 05 September 2006 23:10, Alexander Neundorf wrote: Hi Volker, On Tuesday 05 September 2006 09:50, Volker Krause wrote: On Monday 04 September 2006 23:32, Alexander Neundorf wrote: SVN commit 580957 by neundorf: Remove the FORCE keyword from the various install directories

Re: KDE/kdelibs/cmake/modules

On Wednesday 06 September 2006 22:34, Alexander Neundorf wrote: On Wednesday 06 September 2006 20:07, Alexander Neundorf wrote: On Wednesday 06 September 2006 11:16, Volker Krause wrote: On Tuesday 05 September 2006 23:10, Alexander Neundorf wrote: Hi Volker, On Tuesday 05

Re: KDE/kdepim/akonadi

On Tuesday 12 August 2008 18:11:20 Jaroslaw Staniek wrote: SVN commit 845918 by staniek: replaced DATA_INSTALL_DIR with KDE4_DATA_DIR in macro kcfg_generate_dbus_interface; DATA_INSTALL_DIR is apparently empty in this context on Windows I think this will break if kdepimlibs is installed into

Re: Problem with dependencies

On Tuesday 27 October 2009 16:42:26 Michael Jansen wrote: Hi Because of some qt problem i had to deactivate Nepomuk. It is a optional dependency in kdebase/runtime. Specifying -DWITH_Nepomuk=0 worked (I have nepomuk compiled. onto2vocab... just crashes on execution). It is only on the

Re: Problem with dependencies

On Wednesday 28 October 2009 18:55:06 Alexander Neundorf wrote: On Wednesday 28 October 2009, Volker Krause wrote: On Tuesday 27 October 2009 16:42:26 Michael Jansen wrote: Hi Because of some qt problem i had to deactivate Nepomuk. It is a optional dependency in kdebase/runtime

Re: Problem with dependencies

On Thursday 29 October 2009 19:49:09 Alexander Neundorf wrote: On Thursday 29 October 2009, Volker Krause wrote: On Wednesday 28 October 2009 18:55:06 Alexander Neundorf wrote: ... As Michael already asked, can you give a bit more detail on this ? What I can imagine in issues

Re: KDE/kdelibs

On Thursday 26 November 2009 18:01:31 Alexander Neundorf wrote: On Thursday 26 November 2009, Volker Krause wrote: On Thursday 26 November 2009 00:47:33 Alexander Neundorf wrote: SVN commit 1054396 by neundorf: Revert the new cmake module committed without any review or announcement

Re: [Kde-pim] [PATCH] Making Soprano optional (again) in kdelibs

On Wednesday 30 December 2009 17:53:14 Jorge Manuel B. S. Vicetto wrote: On 30-12-2009 11:45, Kevin Krammer wrote: On Wednesday, 2009-12-30, Jorge Manuel B. S. Vicetto wrote: On 29-12-2009 23:09, Mike Arthur wrote: On 29 Dec 2009, at 23:43, Jorge Manuel B. S. Vicetto wrote: As Maciej

macro_optional_find_package and case-sensitivity

Hi, I just run into some build issues in kdelibs related to libattica on Windows and wanted to take the shortcut and simply disable it setting WITH_LibAttica (which is evaluated by macro_optional_find_package) to false. However, that didn't work. AFAICS this is caused by

Re: new scripts to drive nightly builds available, please try

On Tuesday 27 April 2010 22:05:01 Alexander Neundorf wrote: On Tuesday 20 April 2010, Alexander Neundorf wrote: Hi, in KDE svn in kdesdk/cmake/nightly-support/ there are now in the subdirs KDE/ and kdesupport/ new ctest scripts available for running nightly builds. Compared to the

Re: new scripts to drive nightly builds available, please try

On Sunday 02 May 2010 14:26:56 Alexander Neundorf wrote: On Sunday 02 May 2010, Volker Krause wrote: My Linux build still runs on a simple shell script, my Windows/mingw build Can you post that script here ? I'd like to have a look at it. attached, but rather boring and relies heavily

Re: new scripts to drive nightly builds available, please try

On Monday 03 May 2010 21:46:36 Alexander Neundorf wrote: On Monday 03 May 2010, Volker Krause wrote: On Sunday 02 May 2010 14:26:56 Alexander Neundorf wrote: On Sunday 02 May 2010, Volker Krause wrote: My Linux build still runs on a simple shell script, my Windows/mingw build

Re: KDE/kdelibs/cmake/modules

On Monday 26 July 2010 21:17:28 Alexander Neundorf wrote: On Monday 12 July 2010, Andreas Holzammer wrote: SVN commit 1149092 by aholzammer: - fixed some find scripts for wince M +6 -0 FindKDE4Internal.cmake M +2 -2 KDE4Macros.cmake Hi Andreas, it's very nice that

Re: buildsystem BoF At Akademy/Desktop Summit in Berlin ?

On Tuesday 21 June 2011 21:39:35 Alexander Neundorf wrote: Hi, I'm thinking about setting up a buildsystem BoF for Berlin. Actually I don't have anything fixed planned. It could be just that the people interested in the buildsystem stuff meet. Or we could go again through the plan from

Re: buildsystem BoF At Akademy/Desktop Summit in Berlin ?

On Thursday 23 June 2011 10:23:55 Alexander Neundorf wrote: On Thursday 23 June 2011, Volker Krause wrote: On Tuesday 21 June 2011 21:39:35 Alexander Neundorf wrote: Hi, I'm thinking about setting up a buildsystem BoF for Berlin. Actually I don't have anything fixed planned

Re: Umbrello wants to add the svn version to it's version string

On Sunday 10 July 2011 18:18:01 Michael Jansen wrote: Hi With commit 5d5674cbd26deecbb82c76c55581b21957b00508 in kdesdk andi tried to add the subversion string to the umbrello version. The current implementation has some drawbacks. - Only works in svn checkouts (yeah i know) - Fails

Re: Summary from Buildsystem BoF at Desktop Summit

On Monday 15 August 2011 23:31:26 Alexander Neundorf wrote: - 8) Testing - We shortly discussed testing, continuous builds and nightly builds. I hope Volker (or somebody) can write a better summary. Volker has

Re: Summary from Buildsystem BoF at Desktop Summit

On Wednesday 17 August 2011 07:11:21 henry7...@gmail.com wrote: Very interesting, but it appears to assume all the world is linux x86 (these days probably x86-64, but the such VMs wouldn't run on any 32 bit machines that might be left). Many of our big problems are things that work fine there,

Re: Summary from Buildsystem BoF at Desktop Summit

On Wednesday 17 August 2011 10:59:53 Torgny Nyblom wrote: On Wed, 17 Aug 2011 09:21:33 +0200, Volker Krause wrote: On Monday 15 August 2011 23:31:26 Alexander Neundorf wrote: - 8) Testing - [...] ok, so

Re: What to do with _set_fancy?

On Sunday 18 September 2011 14:28:11 Alexander Neundorf wrote: On Saturday, September 17, 2011 09:13:38 PM Stephen Kelly wrote: Alexander Neundorf wrote: On Friday, September 16, 2011 04:56:35 PM Stephen Kelly wrote: Alexander Neundorf wrote: On Tuesday, September 13, 2011 08:27:27 PM

Re: Review Request 124740: Also set the default visibility for C code to hidden.

marked as submitted. Review request for Extra Cmake Modules. Changes --- Submitted with commit 2b0951d3b6b3740b12a2cc3eedf8b3d1f6eba943 by Volker Krause to branch master. Repository: extra-cmake-modules Description --- This prevents accidental leaking of symbols from internal code

Re: [Kde-pim] kdepim unbuildable with kdesrc-build

On Monday 24 August 2015 13:34:52 Christophe Giboudeaux wrote: Hi, On lundi 24 août 2015 11:42:10 CEST Volker Krause wrote: Hi Martin, sorry about that. I'm not exactly sure what is wrong here, I use kdesrc-build myself, for kdepim and everything else of KDE I use, and never had

Review Request 124740: Also set the default visibility for C code to hidden.

://git.reviewboard.kde.org/r/124740/diff/ Testing --- Thanks, Volker Krause ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 125631: Fix ECMInstallIconsTest.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125631/#review86850 --- looks good to me - Volker Krause On Oct. 14, 2015, 11:16

Re: Review Request 125192: Update GTK icon cache when installing icons.

should disable this for normal distro builds, same as we do already for e.g. updating the mime database. - Volker --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125192/#review8

Re: Review Request 125192: Update GTK icon cache when installing icons.

ard.kde.org/r/125192/#review85254 --- On Sept. 12, 2015, 12:23 p.m., Volker Krause wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125192: Update GTK icon cache when installing icons.

marked as submitted. Review request for Extra Cmake Modules and Olivier Goffart. Changes --- Submitted with commit 12908eafb494ed32a96a5573f0446cc1528265ca by Volker Krause to branch master. Repository: extra-cmake-modules Description --- Despite the name, Qt is also using

Re: Review Request 125192: Update GTK icon cache when installing icons.

system is stepping a bit too far into > packager area. With my Gentoo hat on. Worth asking jriddel what he thinks. > > Volker Krause wrote: > This is purely meant for developer builds, not distros. There this is > better done in post install hooks indeed. The DESTDIR check around thi

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk, vkrause Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

vkrause added a comment. Another +1, would also help the KDE Yocto recipes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D8790: Add FindSasl2.cmake to ECM

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D8790 To: cgiboudeaux, #kde_pim, vkrause Cc: #frameworks, #build_system, dvasin, winterz, vkrause, mlaurent,

D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH dropQT_USE_FAST_OPERATOR_PLUS REVISION DETAIL https://phabricator.kde.org/D13800 To: kossebau, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D13403: Android: Make it possible to override a target's APK directory

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D13403 REVISION DETAIL https://phabricator.kde.org/D13403 To: apol, #frameworks, vkrause Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh,

D9899: Android: Add more includes

vkrause added a comment. Sounds familiar: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 Your patch looks like a viable workaround to me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9899 To: aacid Cc: vkrause, #frameworks, #build_system

D10599: Fix include path for x86 targets

This revision was automatically updated to reflect the committed changes. Closed by commit R240:16844390dab7: Fix include path for x86 targets (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10599?vs=27392=27396 REVISION

D10600: Set ANDROID in the Android toolchain file

This revision was automatically updated to reflect the committed changes. Closed by commit R240:132b95190a31: Set ANDROID in the Android toolchain file (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10600?vs=27393=27397

D10599: Fix include path for x86 targets

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY ANDROID_TOOLCHAIN is "x86" there, while the

D10602: Remove obsolete policy settings

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY Those affect policy propagation and search

D10600: Set ANDROID in the Android toolchain file

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This allows easy platforms checks in CMake

D10599: Fix include path for x86 targets

vkrause added a comment. Interesting, @dfaure, does setting a different ABI/compiler via the command line actually work for you? Here the command-line parameters are not propagated to compiler runs for configure checks, so they run with the defaults from the toolchain file, which fails at

D10777: Define __ANDROID_API__

This revision was automatically updated to reflect the committed changes. Closed by commit R240:bbf792fc28c2: Define __ANDROID_API__ (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10777?vs=27875=27902#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST

D10777: Define __ANDROID_API__

vkrause added a comment. In D10777#212384 , @apol wrote: > I've never seen these so I'm surprised. Good that you figured it out though :) As long as you stick with Qt API this probably doesn't matter, I only ran into this with libc API.

D10777: Define __ANDROID_API__

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This is needed for NDK headers to work

D10625: Fix readelf command name on x86

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY The prefix for the command is

D10602: Remove obsolete policy settings

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e0f78079800c: Remove obsolete policy settings (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10602?vs=27399=27470 REVISION

D10625: Fix readelf command name on x86

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ca65aab3a12b: Fix readelf command name on x86 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10625?vs=27448=27471 REVISION

D10601: Extend search path for NDK dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R240:37c2eba28855: Extend search path for NDK dependencies (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10601?vs=27398=27469

D13403: Android: Make it possible to override a target's APK directory

vkrause added inline comments. INLINE COMMENTS > ECMAndroidDeployQt.cmake:58 > +COMMAND LANG=C cmake > -DINPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json.in2" > -DOUTPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json" > "-DTARGET=$" > "-DOUTPUT_DIR=$" >

D14544: Android: Don't hardcode a random version of the Android SDK

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14544 To: apol, #frameworks, vkrause Cc: alexeymin, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D14187: Fix variable definition check

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14187 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

vkrause added a comment. In D11776#318339 , @Martchus wrote: > @vkrause Thanks for confirming. So it is not a local issue. Could you find a workaround (beside reverting these changes)? I edit the file `stl` in the build dir to strip out

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

vkrause added a comment. It's the same issue I have here, but after our discussion at Akademy I assumed this to be local setup issue. Similar versions here, on Tumbleweed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks,

D11181: Resolve symlinks in QML import paths

This revision was automatically updated to reflect the committed changes. Closed by commit R240:919b6be0004d: Resolve symlinks in QML import paths (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11181?vs=29091=29139 REVISION

D11342: Include the "stdcpp-path" in the json file

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks sane to me. Probably needs to be adjusted for clang support eventually though. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D11177: Provide QML import paths to androiddeployqt

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This makes the qmlimportscanner find our QML

D11177: Provide QML import paths to androiddeployqt

This revision was automatically updated to reflect the committed changes. Closed by commit R240:553be332f2e3: Provide QML import paths to androiddeployqt (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11177?vs=29078=29090

D11181: Resolve symlinks in QML import paths

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY qmlimportscanner fails when provided

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Builds fine here, and moving closer to the Android cmake files makes sense IMHO. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D12120: Check if the application androiddeployqt package has a main() symbol

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Just tested that my 64bit host nm can also consume 32bit ARM binaries, seems to work, so not using the corresponding toolchain nm is probably fine here. REPOSITORY R240 Extra CMake

D12172: Android: Also install plugins, otherwise they are just not available

vkrause added a comment. In D12172#245790 , @apol wrote: > Yes, it's something I'd like to look into. I haven't found documentation for it yet. There is none I think, apart from the qmake and androiddeployqt sources ;-( REPOSITORY

D12150: Make it possible to build several apk out of a project

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. I very much like that direction. I always found the need to specify platform-independent build properties explicitly on the command line weird, so anything moving towards being able to

D12172: Android: Also install plugins, otherwise they are just not available

vkrause added a comment. For Qt < 5.12 this is ok as a temporary solution I think, but with the new androiddeployqt I'd rather add -android-dependencies.xml files for the libraries needing plugins (simple example:

D12269: Don't install plugins within lib on android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D12269 To: apol, vkrause Cc: #frameworks, #build_system, michaelh, ngraham, bruns

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Nice! Works fine in my setup too. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #build_system,

D11388: Provide androiddeployqt with all prefix paths

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This is needed for a new feature in Qt 5.12,

D11388: Provide androiddeployqt with all prefix paths

This revision was automatically updated to reflect the committed changes. Closed by commit R240:73a0265c6272: Provide androiddeployqt with all prefix paths (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11388?vs=29676=29743

D15685: Fix Android builds using cmake 3.12.1

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH wop REVISION DETAIL https://phabricator.kde.org/D15685 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16930: Android: improve clang support

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks ok to me, less stuff to set manually is always good. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D16930 To: apol,

D16954: Add find module for Google's libphonenumber

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is currently in use by plasma-phone-components, but will also be needed by

D18243: Fix qmake module generation for Qt 5.12.1

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Patch by Eike Ziller from https://github.com/KDAB/GammaRay/pull/526 in response to Qt

D18243: Fix qmake module generation for Qt 5.12.1

This revision was automatically updated to reflect the committed changes. Closed by commit R240:79bf23008f66: Fix qmake module generation for Qt 5.12.1 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18243?vs=49447=49449

D17547: Bring FindFontconfig.cmake up to ECM standards

vkrause created this revision. vkrause added a reviewer: Build System. Herald added a project: KWin. Herald added a subscriber: kwin. vkrause requested review of this revision. REVISION SUMMARY This is a preparation step to move this to ECM (or possibly CMake), which makes sense now that

D17547: Bring FindFontconfig.cmake up to ECM standards

vkrause updated this revision to Diff 47656. vkrause added a comment. Improve version detection. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17547?vs=47613=47656 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17547 AFFECTED FILES

D17547: Bring FindFontconfig.cmake up to ECM standards

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3bb07ef12d3e: Bring FindFontconfig.cmake up to ECM standards (authored by vkrause). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17547?vs=47656=47783 REVISION

D17547: Bring FindFontconfig.cmake up to ECM standards

vkrause updated this revision to Diff 47613. vkrause added a comment. Address review comments. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17547?vs=47471=47613 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17547 AFFECTED FILES

D16954: Add find module for Google's libphonenumber

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ebb05ecafb02: Add find module for Googles libphonenumber (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16954?vs=46805=46848

D16954: Add find module for Google's libphonenumber

vkrause updated this revision to Diff 46805. vkrause added a comment. Address review comments. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16954?vs=45643=46805 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16954 AFFECTED

D16954: Add find module for Google's libphonenumber

vkrause added a comment. ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16954 To: vkrause, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

vkrause added reviewers: Build System, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16954 To: vkrause, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

vkrause added a comment. IMHO a good idea, +1. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > PythonInterp is also not a solution :) See 6c1db934e > > in ki18n. > > CMake 3.5.0 was found acceptable for most

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > FindPython3.cmake only exists in CMake >= 3.12.0 Right, the feature is just silently ignored in older versions. We can probably switch that to PythonIterp if we want this for older versions as

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is supposed to trigger a unit test failure when using http: rather than https:

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R240:514835418c9d: Restore FindFontconfig backward compatibility for plasma-desktop (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18943: Add Fontconfig find modudle

vkrause added a comment. ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18943 To: vkrause Cc: kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18943: Add Fontconfig find modudle

vkrause added a comment. In D18943#424041 , @kossebau wrote: > In D18943#424029 , @vkrause wrote: > > > What I don't understand though is which FindFontconfig this used to find, there is non in

D19223: Fix releaseme checkout when this is included in a sub-directory

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6daec3f14576: Fix releaseme checkout when this is included in a sub-directory (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D19223: Fix releaseme checkout when this is included in a sub-directory

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes the Marble build on binary factory. REPOSITORY R240 Extra CMake Modules

D19486: Add UDev find module

This revision was automatically updated to reflect the committed changes. Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19486?vs=53055=53160#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST

D19486: Add UDev find module

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This one is originally coming from Solid, but there are several more copies in our

D18943: Add Fontconfig find modudle

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e3b6c8708c48: Add Fontconfig find modudle (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18943?vs=51849=53050#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE

D18943: Add Fontconfig find modudle

vkrause added a comment. In D18943#423969 , @matthieugras wrote: > This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst). Confirmed on a clean rebuild here too.

D18943: Add Fontconfig find modudle

vkrause added a comment. D19499 fixes that here REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18943 To: vkrause, cgiboudeaux Cc: matthieugras, kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY I don't understand where plasma-desktop actually finds that old find module, but this

D19005: android: don't default to gcc anymore

vkrause added a comment. In D19005#414313 , @apol wrote: > In D19005#412258 , @vkrause wrote: > > > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be

  1   2   >