Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Tomaz Canabrava]

On Mon, Dec 5, 2016 at 9:00 AM, Ben Cooksley  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
>
> On November 5th, 2016, 9:14 a.m. UTC, *David Faure* wrote:
>
> Ship It!
>
> On December 3rd, 2016, 11:36 p.m. UTC, *David Faure* wrote:
>
> I withdraw my approval. Please revert.
> I just noticed that these modules have been added for the "frameworks" 
> module-set. This doesn't make sense, they are not part of frameworks. When I 
> type "kdesrc-build frameworks" I expect that only the real KF5 modules will 
> be built.
>
> purpose is in playground/libs. If it's needed by kamoso, then it should be 
> moved to extragear/libs and added to kf5-extragear-build-include. Follow the 
> review process for this to happen.
>
> kirigami is in extragear/libs. If it's required by discover, it should be 
> moved to kde/workspace, and then it can be added in 
> kf5-workspace-build-include (ask the plasma people if they agree, then file a 
> sysadmin request for the move). If it's also needed by applications, then it 
> needs to be turned into a proper framework.
>
> On December 4th, 2016, 9:18 p.m. UTC, *Nicolás Alvarez* wrote:
>
> kamoso in extragear depending on purpose in playground does seem weird, and 
> maybe purpose should be moved to extragear.
>
> However, I don't think a library (kirigami) that is needed by applications 
> should be forced to follow the KF5 release schedule. In terms of versioning, 
> it should be handled the same as a third-party library. They can release when 
> they want, and applications can bump the dependency when they need to.
>
> I'm with David here. Libraries should also stop abusing KF5* - that prefix is 
> exclusively reserved for Frameworks.
>
>
I'll revert, but this thread raised concerns that are way way beyond my
patch, what I wanted with this was just to be able to compile some KDE
software that whas missing, moving an application / library out of
playground (that I don't even commited a single line of code) seems to be
way out of scope for this change.

now, kamoso depends om something that's in playground, not easily
reversible, and I wanna have kamoso on my system (I actually use that),
should I message the kamoso developers to move purpose out of playground?

Tomaz

>
> Due to the manner in which development code often depends on other 
> development code - especially for libraries such as Purpose - i'm strongly in 
> favour of Workspace/Applications only being allowed to depend on libraries in 
> the same release unit or Frameworks (for libraries maintained by KDE anyway).
>
> In any case, depending on Playground should definitely be forbidden (you 
> shouldn't be releasing code from Playground anyway).
>
>
> - Ben
>
> On November 7th, 2016, 9:39 a.m. UTC, Tomaz Canabrava wrote:
> Review request for Build System.
> By Tomaz Canabrava.
>
> *Updated Nov. 7, 2016, 9:39 a.m.*
> *Repository: * kdesrc-build
> Description
>
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
>
> Signed-off-by: Tomaz Canabrava 
>
> Add Kamoso to the buildsystem.
>
> Kamoso was missing from kdegraphics.
>
> Signed-off-by: Tomaz Canabrava 
>
> Diffs
>
>- kf5-applications-build-include (f53c0233ba46322829076db3437cf9
>c62a65ff8e)
>- kf5-frameworks-build-include (a88498e3248262d2e1fddacd726e1e
>f06a3ac1e4)
>
> View Diff 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Michael Pyne]

On Mon, Dec 05, 2016 at 12:40:21PM +0100, Tomaz Canabrava wrote:
> On Mon, Dec 5, 2016 at 9:00 AM, Ben Cooksley  wrote:
> 
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/129117/
> >
> > On December 3rd, 2016, 11:36 p.m. UTC, *David Faure* wrote:
> >
> > I withdraw my approval. Please revert.
> >
> > I'm with David here. Libraries should also stop abusing KF5* - that prefix 
> > is exclusively reserved for Frameworks.
> >
> >
> I'll revert, but this thread raised concerns that are way way beyond my
> patch, what I wanted with this was just to be able to compile some KDE
> software that whas missing, moving an application / library out of
> playground (that I don't even commited a single line of code) seems to be
> way out of scope for this change.

This was part of what I'd been concerned with, but after reading my
initial review I see that I never actually mentioned that except with an
aside about eventually having the relevant git repos move under frameworks/*

> now, kamoso depends om something that's in playground, not easily
> reversible, and I wanna have kamoso on my system (I actually use that),
> should I message the kamoso developers to move purpose out of playground?

That's a good first step, and if it leads to the kamoso devs
occasionally packging purpose that would help our packagers (and
therefore many other users) as well.

However you can also manually include purpose within your local
kdesrc-build configuration so that it's updated and built when you'd
otherwise be building kamoso.

There's various options for doing this.  I'd recommend a shell
kdesrc-buildrc file that uses the "include" declaration to pull in
applicable kf5-*-build-include files from the kdesrc-build git
repository.  See kf5-qt5-build-include for an example.

Regards,
 - Michael Pyne

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Ben Cooksley]

> On Nov. 5, 2016, 9:14 a.m., David Faure wrote:
> > Ship It!
> 
> David Faure wrote:
> I withdraw my approval. Please revert.
> I just noticed that these modules have been added for the "frameworks" 
> module-set. This doesn't make sense, they are not part of frameworks. When I 
> type "kdesrc-build frameworks" I expect that only the real KF5 modules will 
> be built.
> 
> purpose is in playground/libs. If it's needed by kamoso, then it should 
> be moved to extragear/libs and added to kf5-extragear-build-include. Follow 
> the review process for this to happen.
> 
> kirigami is in extragear/libs. If it's required by discover, it should be 
> moved to kde/workspace, and then it can be added in 
> kf5-workspace-build-include (ask the plasma people if they agree, then file a 
> sysadmin request for the move). If it's also needed by applications, then it 
> needs to be turned into a proper framework.
> 
> Nicolás Alvarez wrote:
> kamoso in extragear depending on purpose in playground does seem weird, 
> and maybe purpose should be moved to extragear.
> 
> However, I don't think a library (kirigami) that is needed by 
> applications should be forced to follow the KF5 release schedule. In terms of 
> versioning, it should be handled the same as a third-party library. They can 
> release when they want, and applications can bump the dependency when they 
> need to.

I'm with David here. Libraries should also stop abusing KF5* - that prefix is 
exclusively reserved for Frameworks.

Due to the manner in which development code often depends on other development 
code - especially for libraries such as Purpose - i'm strongly in favour of 
Workspace/Applications only being allowed to depend on libraries in the same 
release unit or Frameworks (for libraries maintained by KDE anyway).

In any case, depending on Playground should definitely be forbidden (you 
shouldn't be releasing code from Playground anyway).


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100589
---


On Nov. 7, 2016, 9:39 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Nov. 7, 2016, 9:39 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Nicolás Alvarez]

> On Nov. 5, 2016, 6:14 a.m., David Faure wrote:
> > Ship It!
> 
> David Faure wrote:
> I withdraw my approval. Please revert.
> I just noticed that these modules have been added for the "frameworks" 
> module-set. This doesn't make sense, they are not part of frameworks. When I 
> type "kdesrc-build frameworks" I expect that only the real KF5 modules will 
> be built.
> 
> purpose is in playground/libs. If it's needed by kamoso, then it should 
> be moved to extragear/libs and added to kf5-extragear-build-include. Follow 
> the review process for this to happen.
> 
> kirigami is in extragear/libs. If it's required by discover, it should be 
> moved to kde/workspace, and then it can be added in 
> kf5-workspace-build-include (ask the plasma people if they agree, then file a 
> sysadmin request for the move). If it's also needed by applications, then it 
> needs to be turned into a proper framework.

kamoso in extragear depending on purpose in playground does seem weird, and 
maybe purpose should be moved to extragear.

However, I don't think a library (kirigami) that is needed by applications 
should be forced to follow the KF5 release schedule. In terms of versioning, it 
should be handled the same as a third-party library. They can release when they 
want, and applications can bump the dependency when they need to.


- Nicolás


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100589
---


On Nov. 7, 2016, 6:39 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Nov. 7, 2016, 6:39 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[David Faure]

> On Nov. 5, 2016, 9:14 a.m., David Faure wrote:
> > Ship It!

I withdraw my approval. Please revert.
I just noticed that these modules have been added for the "frameworks" 
module-set. This doesn't make sense, they are not part of frameworks. When I 
type "kdesrc-build frameworks" I expect that only the real KF5 modules will be 
built.

purpose is in playground/libs. If it's needed by kamoso, then it should be 
moved to extragear/libs and added to kf5-extragear-build-include. Follow the 
review process for this to happen.

kirigami is in extragear/libs. If it's required by discover, it should be moved 
to kde/workspace, and then it can be added in kf5-workspace-build-include (ask 
the plasma people if they agree, then file a sysadmin request for the move). If 
it's also needed by applications, then it needs to be turned into a proper 
framework.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100589
---


On Nov. 7, 2016, 9:39 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Nov. 7, 2016, 9:39 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Tomaz Canabrava]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/
---

(Updated Nov. 7, 2016, 9:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for Build System.


Repository: kdesrc-build


Description
---

Kirigami is now needed to run discover, so it should be build
Purpose is needed by at least kamoso.

Signed-off-by: Tomaz Canabrava 

Add Kamoso to the buildsystem.

Kamoso was missing from kdegraphics.

Signed-off-by: Tomaz Canabrava 


Diffs
-

  kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
  kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 

Diff: https://git.reviewboard.kde.org/r/129117/diff/


Testing
---


Thanks,

Tomaz  Canabrava

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100589
---


Ship it!




Ship It!

- David Faure


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Michael Pyne]

> On Oct. 15, 2016, 8:51 p.m., Michael Pyne wrote:
> > kf5-applications-build-include, line 26
> > 
> >
> > If the idea is to build everything in kdegraphics then it is probably 
> > better to replace all of these sub-modules with something like `use-modules 
> > kde/kdegraphics`.
> > 
> > The `kde/` is itself redundant and unnecessary, that's just an effort 
> > to make it clear it's not simply a single repository name.
> 
> David Faure wrote:
> Michael: my goal was to have a way to build *everything* that is KF5/Qt5 
> ready. This does mean adding each and every module into a file somewhere, 
> although of course people don't have to include these files. My idea was, one 
> file per "product", so people can grab "all of frameworks" or "all of plasma" 
> or "all apps", and if they want a subset they can just copy/paste that subset 
> they want to compile into their own file. Defining instead what is 
> "essential" and what is not sounds like a very fuzzy topic, subject to 
> endless debates.

If you'd like to +1 that's fine by me, and while it does raise the question of 
how we debate when a playground module is ready for KF5/Qt5, that's a debate 
that can at least be more easily answered by the individual application authors 
than the debate about which modules are 'essential'.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100026
---


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[David Faure]

> On Oct. 15, 2016, 8:51 p.m., Michael Pyne wrote:
> > kf5-applications-build-include, line 26
> > 
> >
> > If the idea is to build everything in kdegraphics then it is probably 
> > better to replace all of these sub-modules with something like `use-modules 
> > kde/kdegraphics`.
> > 
> > The `kde/` is itself redundant and unnecessary, that's just an effort 
> > to make it clear it's not simply a single repository name.

Michael: my goal was to have a way to build *everything* that is KF5/Qt5 ready. 
This does mean adding each and every module into a file somewhere, although of 
course people don't have to include these files. My idea was, one file per 
"product", so people can grab "all of frameworks" or "all of plasma" or "all 
apps", and if they want a subset they can just copy/paste that subset they want 
to compile into their own file. Defining instead what is "essential" and what 
is not sounds like a very fuzzy topic, subject to endless debates.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100026
---


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Michael Pyne]

> On Oct. 15, 2016, 8:51 p.m., Michael Pyne wrote:
> > I think at some point I will want to find a way to have the 
> > kf5-*-build-include files be a reduced set of modules nearly everyone 
> > agrees are essential, and then have a user's own desired module-sets be 
> > picked up based on a separate file, that way we don't have to add every KF5 
> > and Plasma5 module into the sample KF5-based configuration. But that's 
> > neither here nor there...
> > 
> > The changes make sense but I would recommend some differences.
> > 
> > I think it would be better to have the repos that are currently in 
> > extragear or playground (but eventually destined for KF5) to be factored 
> > out into their own separate module-set. Once they enter KF5 they should be 
> > removed from kf5-frameworks-build-include since kdesrc-build will find them 
> > automatically, but if every such module is spread across multiple 
> > kf5-*-build-include files it will make that cleanup that much harder.
> > 
> > The kamoso comment below is similar -- if we rely on manually adding repo 
> > names to kf5-*-build-include then many users will simply never build or 
> > test these repos.
> 
> Tomaz  Canabrava wrote:
> kirigami is essential for two apps currently, one in kdebase-apps: peruse 
> and discover, while 'purpose' only for kamoso.
> do you want me to split the commits?

I don't think splitting is necessary, no. Just as long as all the "will be 
moved under kde/* or frameworks/* soon" modules are in a reasonably central 
place.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100026
---


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Tomaz Canabrava]

> On Oct. 15, 2016, 8:51 p.m., Michael Pyne wrote:
> > I think at some point I will want to find a way to have the 
> > kf5-*-build-include files be a reduced set of modules nearly everyone 
> > agrees are essential, and then have a user's own desired module-sets be 
> > picked up based on a separate file, that way we don't have to add every KF5 
> > and Plasma5 module into the sample KF5-based configuration. But that's 
> > neither here nor there...
> > 
> > The changes make sense but I would recommend some differences.
> > 
> > I think it would be better to have the repos that are currently in 
> > extragear or playground (but eventually destined for KF5) to be factored 
> > out into their own separate module-set. Once they enter KF5 they should be 
> > removed from kf5-frameworks-build-include since kdesrc-build will find them 
> > automatically, but if every such module is spread across multiple 
> > kf5-*-build-include files it will make that cleanup that much harder.
> > 
> > The kamoso comment below is similar -- if we rely on manually adding repo 
> > names to kf5-*-build-include then many users will simply never build or 
> > test these repos.

kirigami is essential for two apps currently, one in kdebase-apps: peruse and 
discover, while 'purpose' only for kamoso.
do you want me to split the commits?


- Tomaz


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100026
---


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

Re: Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Michael Pyne]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100026
---



I think at some point I will want to find a way to have the kf5-*-build-include 
files be a reduced set of modules nearly everyone agrees are essential, and 
then have a user's own desired module-sets be picked up based on a separate 
file, that way we don't have to add every KF5 and Plasma5 module into the 
sample KF5-based configuration. But that's neither here nor there...

The changes make sense but I would recommend some differences.

I think it would be better to have the repos that are currently in extragear or 
playground (but eventually destined for KF5) to be factored out into their own 
separate module-set. Once they enter KF5 they should be removed from 
kf5-frameworks-build-include since kdesrc-build will find them automatically, 
but if every such module is spread across multiple kf5-*-build-include files it 
will make that cleanup that much harder.

The kamoso comment below is similar -- if we rely on manually adding repo names 
to kf5-*-build-include then many users will simply never build or test these 
repos.


kf5-applications-build-include (line 26)


If the idea is to build everything in kdegraphics then it is probably 
better to replace all of these sub-modules with something like `use-modules 
kde/kdegraphics`.

The `kde/` is itself redundant and unnecessary, that's just an effort to 
make it clear it's not simply a single repository name.


- Michael Pyne


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> ---
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> ---
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava 
> 
> 
> Diffs
> -
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>