Re: Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap

2011-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103425/#review8990 --- Ship it! good catch - Marco Martin On Dec. 15, 2011, 11:09

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2011-12-16 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/ --- (Updated Dec. 16, 2011, 8:41 a.m.) Review request for kdelibs and

Re: Review Request: Add 20px margin when to info pages generated by kio_info

2011-12-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103426/#review8994 --- please use 20pt or 1em - even todays notebooks often have

Re: Review Request: check if enough disk space available before even starting to copy each file

2011-12-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103412/#review8996 --- this whole file needs a reformat into kdelibs style, though

Re: Review Request: Crash guard for KSelectionProxyModelPrivate::removeRangeFromProxy()

2011-12-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103421/#review8997 --- Ship it! other than the style issue, this looks good :)

Re: Review Request: Crash guard for KSelectionProxyModelPrivate::removeRangeFromProxy()

2011-12-16 Thread Stephen Kelly
Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103421/#review8997 --- Ship it! other than the style

Re: Review Request: check if enough disk space available before even starting to copy each file

2011-12-16 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103412/ --- (Updated Dec. 16, 2011, 1:28 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add 20px margin when to info pages generated by kio_info

2011-12-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103426/ --- (Updated Dec. 16, 2011, 2:13 p.m.) Review request for KDE Runtime.

Re: Review Request: Add 1em right padding to info pages generated by kio_info

2011-12-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103426/ --- (Updated Dec. 16, 2011, 2:15 p.m.) Review request for KDE Runtime.

Re: Review Request: Add 1em right padding to info pages generated by kio_info

2011-12-16 Thread Dawit Alemayehu
On Dec. 16, 2011, 10:50 a.m., Thomas Lübking wrote: please use 20pt or 1em - even todays notebooks often have =150dpi and you can expect this value to rise (macbook rumors...) Thomas Lübking wrote: errr... soryr for this probably stupid question, but why isn't the

Review Request: Reset time format upon user request

2011-12-16 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- Review request for kdelibs and Plasma. Description --- The patch

Re: Review Request: Add 1em right padding to info pages generated by kio_info

2011-12-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103426/#review9017 --- This review has been submitted with commit

Re: Review Request: Reset time format upon user request

2011-12-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9018 --- i've made it so that kcmlocale also emit the signal ... now we

Re: Review Request: Reset time format upon user request

2011-12-16 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- (Updated Dec. 16, 2011, 9:13 p.m.) Review request for kdelibs and Plasma.