Re: Review Request 106475: Check if the startDir has an schema before discarting it

2013-01-16 Thread David Faure
On Oct. 4, 2012, 4:28 p.m., Christoph Feck wrote: Causes a regression. When using Save Image As... in Konqueror, the file dialog starts at Custom Path (and lists root folder), without remembering the previously used path. Jonathan Marten wrote: Doing the test as follows appears

Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2013-01-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108433/ --- Review request for kde-workspace. Description --- This makes the row

Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-01-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108434/ --- Review request for kdelibs. Description --- It took me hours

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2013-01-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108433/ --- (Updated Jan. 16, 2013, 1:56 a.m.) Review request for kde-workspace.

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-01-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108434/#review25636 --- instead of maintoolbar (which could be 128px on even a

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2013-01-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108433/#review25637 --- kcontrol/colors/colorscm.cpp

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2013-01-16 Thread Thomas Lübking
On Jan. 16, 2013, 10:10 a.m., Thomas Lübking wrote: kcontrol/colors/colorscm.cpp, line 747 http://git.reviewboard.kde.org/r/108433/diff/1/?file=107425#file107425line747 w/o having checked code it seems the view has a static row height and the last kid would by this set the game.

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-01-16 Thread Thomas Lübking
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Kai Uwe Broulik wrote: Main toolbar icon size is only settable from 16 to 48 pixels and

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2013-01-16 Thread Kai Uwe Broulik
On Jan. 16, 2013, 10:10 a.m., Thomas Lübking wrote: kcontrol/colors/colorscm.cpp, line 747 http://git.reviewboard.kde.org/r/108433/diff/1/?file=107425#file107425line747 w/o having checked code it seems the view has a static row height and the last kid would by this set the game.

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-01-16 Thread Kai Uwe Broulik
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Main toolbar icon size is only settable from 16 to 48 pixels and defaults to 22. And if you

Re: Review Request 108433: [High-dpi issues] Fix color kcm list when using big fonts

2013-01-16 Thread Kai Uwe Broulik
On Jan. 16, 2013, 10:10 a.m., Thomas Lübking wrote: kcontrol/colors/colorscm.cpp, line 747 http://git.reviewboard.kde.org/r/108433/diff/1/?file=107425#file107425line747 w/o having checked code it seems the view has a static row height and the last kid would by this set the game.

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-01-16 Thread Kai Uwe Broulik
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Kai Uwe Broulik wrote: Main toolbar icon size is only settable from 16 to 48 pixels and

Re: Review Request 107829: Correctly trigger executed signal of KListWidget for both single click and double click.

2013-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107829/#review25657 --- This review has been submitted with commit

Review Request 108440: More readable fix for the KFileWidget startDir issue.

2013-01-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108440/ --- Review request for kdelibs, Àlex Fiestas, Christoph Feck, and Jonathan

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-01-16 Thread Thomas Lübking
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Kai Uwe Broulik wrote: Main toolbar icon size is only settable from 16 to 48 pixels and

Re: Review Request 108430: Fix i18n context handling in kconfig_compiler

2013-01-16 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108430/#review25687 --- Ship it! Looks good to me. - Chusslove Illich On Jan. 15,

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-16 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 16, 2013, 2:37 p.m.) Review request for kdelibs, kwin,

Review Request 108442: [High-dpi issues] Fix KIconButton initial icon size and its occurence in KPropertiesDialog

2013-01-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108442/ --- Review request for kdelibs. Description --- The KIconButton and the