Re: Review Request 104417: Copy files instead of moving if parent dir is not writable

2013-02-09 Thread Ivan Čukić
On Feb. 8, 2013, 11 p.m., Albert Astals Cid wrote: Lamarque? Ivan? Are you guys working on this or should I just mark it as discarded? You can mark it as discarded - there are no more private activities - Ivan --- This is an

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-02-09 Thread Kai Uwe Broulik
On July 12, 2012, 4:17 p.m., David Faure wrote: Looks good. For master only, though, given feature+message freeze in 4.9. Kai Uwe Broulik wrote: Totally forgot to commit this :( Will do for master (4.10) once my ssh key for my new notebook got imported. Albert Astals Cid wrote:

Re: Removing WinCE support

2013-02-09 Thread Alexander Neundorf
On Thursday 10 May 2012, Alexander Neundorf wrote: On Thursday 10 May 2012, Volker Krause wrote: On Wednesday 09 May 2012 16:47:17 Stephen Kelly wrote: Alexander Neundorf wrote: Hi, KDAB made kdelibs in some way work with Win CE. Now Win CE is a very different OS, and

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-02-09 Thread Kai Uwe Broulik
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Kai Uwe Broulik wrote: Main toolbar icon size is only settable from 16 to 48 pixels and

Re: Login for bug reporting

2013-02-09 Thread Jekyll Wu
On 2013年02月07日 01:56, Kevin Krammer wrote: Hi at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report crashes via the KDE crash handler dialog. The issue in his case was kind of made worse by having this

Re: Login for bug reporting

2013-02-09 Thread Jekyll Wu
On 2013年02月07日 17:21, Kevin Krammer wrote: It was definitely the process of creating an account, the developer was explicitly stating that providing an email address isn't the problem. Does the crash report dialog offer the option of creating an account? Does it store the password so that it

Re: Login for bug reporting

2013-02-09 Thread Jekyll Wu
On 2013年02月07日 18:29, Martin Gräßlin wrote: Also spend a moment and look at the report. There is multiple times written that we don't want any further comments on the bug and that doesn't help anything. Still attachements, still duplicates. I guess you are talking about

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-02-09 Thread Thomas Lübking
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Kai Uwe Broulik wrote: Main toolbar icon size is only settable from 16 to 48 pixels and

Re: Login for bug reporting

2013-02-09 Thread Martin Graesslin
On Sunday 10 February 2013 16:40:06 Jekyll Wu wrote: On 2013年02月07日 18:29, Martin Gräßlin wrote: Also spend a moment and look at the report. There is multiple times written that we don't want any further comments on the bug and that doesn't help anything. Still attachements, still

Re: Review Request 108237: [Bug 286768] Duplicate entries in KWallet default wallet comboBox

2013-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108237/#review27063 --- This review has been submitted with commit

Re: Review Request 108434: [High-dpi issues] Fix icon in KPageDialog that shows up in every KCM being hardcoded to 22px

2013-02-09 Thread Christoph Feck
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote: instead of maintoolbar (which could be 128px on even a netbook) maybe relate it to the font height? (what seems to be the idea behind 22px) Kai Uwe Broulik wrote: Main toolbar icon size is only settable from 16 to 48 pixels and

Re: Login for bug reporting

2013-02-09 Thread Martin Sandsmark
On Sat, Feb 09, 2013 at 03:25:12PM +0100, Martin Graesslin wrote: and a feedback channel. E.g. for that bug there was one setting to change and it would have been great to just be able to tell the users that in an easy way. I wish there was a way to have a summary on top in all bugs,

Re: Request: Move of kdev-perforce plugin from playground to extragear

2013-02-09 Thread Albert Astals Cid
El Divendres, 8 de febrer de 2013, a les 19:31:07, Burkhard Lück va escriure: Am Donnerstag, 7. Februar 2013, 23:31:38 schrieb Morten Volden: Hi All I have created a sysadmin request to move kdev-perforce to extragear: Scripty mailed me kdev-perforce arrived in kdereview this morning,

Review Request 108875: Port Sonnet to QPluginLoader

2013-02-09 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/ --- Review request for KDE Frameworks and kdelibs. Description --- Port

Re: Review Request 108875: Port Sonnet to QPluginLoader

2013-02-09 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/ --- (Updated Feb. 9, 2013, 4:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 108875: Port Sonnet to QPluginLoader

2013-02-09 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/ --- (Updated Feb. 9, 2013, 5:02 p.m.) Review request for KDE Frameworks and

Re: Review Request 108875: Port Sonnet to QPluginLoader

2013-02-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/#review27081 --- Cool. Just a bunch of minor things.

Re: Review Request 107678: Keep clickmessage text visible when empty and focused

2013-02-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107678/#review27083 --- Ship it! +1 for consistency. - David Faure On Dec. 12,

Re: Review Request 108875: Port Sonnet to QPluginLoader

2013-02-09 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/ --- (Updated Feb. 9, 2013, 6:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 108875: Port Sonnet to QPluginLoader

2013-02-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108875/#review27092 --- Ship it! Ship It! staging/sonnet/src/core/CMakeLists.txt

Re: Review Request 101885: KRecentDocument support for the K Activity Manager Daemon

2013-02-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101885/#review27101 --- Wow, this is old, what happened to this? - Albert Astals Cid

Re: Review Request 101272: KMessageWidget: Adapt height to text changes

2013-02-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101272/#review27103 --- I'm closing the review based on Aurelien's comment - Albert

Re: Review Request 101885: KRecentDocument support for the K Activity Manager Daemon

2013-02-09 Thread Ivan Čukić
On Feb. 9, 2013, 9:53 p.m., Albert Astals Cid wrote: Wow, this is old, what happened to this? Waits for the better days :) (KF5) - Ivan --- This is an automatically generated e-mail. To reply, visit: