Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

2013-03-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109675/#review29781 --- I like the idea, but I would prefer using

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-03-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated March 23, 2013, 8:06 p.m.) Review request for kdelibs, kwin,

Re: KSaveFile, QSaveFile, QFile

2013-03-24 Thread David Faure
On Thursday 21 March 2013 19:02:13 David Faure wrote: I'm afraid it's one or the other: * safe code, always a working file available, but hardlinks get splitted up * possibility to corrupt the existing file, but a backup exists; hardlinks are kept. OK, bug number 2, saving into a

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Laurent Montel
On March 22, 2013, 5:38 p.m., Laurent Montel wrote: For me seems good. Regards Sven Brauch wrote: Sorry to annoy you again ;) just to make sure, I'd push this to kdelibs master now, ok? I hope nobody will mind the increase in the required attica version... yes in master.

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29797 --- This review has been submitted with commit

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 24, 2013, 12:55 p.m.) Status -- This change has been

Re: Review Request 109561: Disable SSL compression support in TCPSlaveBase

2013-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109561/#review29801 --- This review has been submitted with commit

Re: Review Request 109561: Disable SSL compression support in TCPSlaveBase

2013-03-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109561/ --- (Updated March 24, 2013, 3:05 p.m.) Status -- This change has been

Re: KSaveFile, QSaveFile, QFile

2013-03-24 Thread Christoph Cullmann
On Thursday 21 March 2013 19:02:13 David Faure wrote: I'm afraid it's one or the other: * safe code, always a working file available, but hardlinks get splitted up * possibility to corrupt the existing file, but a backup exists; hardlinks are kept. OK, bug number 2, saving into a

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-24 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29802 --- after extensive deliberation of the code i found that ... i

Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog

2013-03-24 Thread Sven Brauch
On March 22, 2013, 5:38 p.m., Laurent Montel wrote: For me seems good. Regards Sorry to annoy you again ;) just to make sure, I'd push this to kdelibs master now, ok? I hope nobody will mind the increase in the required attica version... - Sven

Re: KSaveFile, QSaveFile, QFile

2013-03-24 Thread Dominik Haumann
On Sunday, 24. March 2013 16:25:20 Christoph Cullmann wrote: On Thursday 21 March 2013 19:02:13 David Faure wrote: I'm afraid it's one or the other: * safe code, always a working file available, but hardlinks get splitted up * possibility to corrupt the existing file, but a backup