Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/ --- Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and

Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112128/ --- Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

> On Aug. 16, 2013, 6:19 p.m., Albert Astals Cid wrote: > > kcontrol/dateandtime/dtime.cpp, line 101 > > > > > > Maybe just use KLocale::timeFomat()? > > Christoph Feck wrote: > Was thinking about it, and fea

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112122/#review38008 --- Ship it! Ship It! - Albert Astals Cid On Aug. 16, 2013, 3:2

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

> On Aug. 16, 2013, 6:19 p.m., Albert Astals Cid wrote: > > kcontrol/dateandtime/dtime.cpp, line 101 > > > > > > Maybe just use KLocale::timeFomat()? Was thinking about it, and feared users might change the defau

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/ --- (Updated Aug. 16, 2013, 7:16 p.m.) Review request for kdelibs, KDE Utils a

Re: Review Request 112122: Respect user's 12/24 h preference in System Settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112122/#review37973 --- kcontrol/dateandtime/dtime.cpp

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

> On Aug. 16, 2013, 5:40 p.m., Christoph Feck wrote: > > Daniel Laidig is the maintainer for KCharSelect stuff, I do not know, if he > > monitors kde lists, though. If you cannot add him as a reviewer, try > > mailing him the link. > > > > He might suggest that this data is better integrated i

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/#review37967 --- Daniel Laidig is the maintainer for KCharSelect stuff, I do not

Review Request 112122: Respect user's 12/24 h preference in System Settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112122/ --- Review request for kde-workspace, Albert Astals Cid and John Layt. Descrip

Re: Review Request 112042: Fix for Konqueror crash when adding/importing bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112042/#review37717 --- sorry, forgot to push my pending review... konqueror/src/konq

Re: Review Request 112042: Fix for Konqueror crash when adding/importing bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112042/ --- (Updated Aug. 16, 2013, 1:06 p.m.) Status -- This change has been mar

Re: Review Request 112042: Fix for Konqueror crash when adding/importing bookmarks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112042/#review37954 --- This review has been submitted with commit d1963e23ddfd64c4ffb

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

> On Aug. 12, 2013, 4:48 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Can you please "forward" this patch to Dolphin's fork of the KPlacesView? > > I'm sure they need this patch as well. > > > > Thanks ! You are right, the code is identical there. https://git.reviewboard.kde.org/r/

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/ --- (Updated Aug. 16, 2013, 12:34 p.m.) Status -- This change has been ma

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37949 --- This review has been submitted with commit 31fdb4ab1b72fa39290

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/#review37938 --- This review has been submitted with commit 9c61f8d8f933949e3e2

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/ --- (Updated Aug. 16, 2013, 9:26 a.m.) Status -- This change has been mar

KDE theme colors API for QML

Hey all! I want to implement API to access KDE theme colors from QML to use in games or other applications. For example it will allow us to implement KGamePopupItem substitution for QML. Now developer need to make own custom c++ writen class to access colors through Q_PROPERTY using. But we can't

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

> On Aug. 15, 2013, 10:55 a.m., Heinz Wiesinger wrote: > > How does this compare to "rbt patch"? > > (http://www.reviewboard.org/docs/rbtools/0.5/rbt/commands/patch/) > > > > It sounds to me like it's meant to accomplish the same thing > > David Edmundson wrote: > That applies a patch to s

Re: Review Request 112081: Add reviewboard-am, a tool to apply patches from KDE reviewboard

> On Aug. 15, 2013, 12:55 p.m., Heinz Wiesinger wrote: > > How does this compare to "rbt patch"? > > (http://www.reviewboard.org/docs/rbtools/0.5/rbt/commands/patch/) > > > > It sounds to me like it's meant to accomplish the same thing > > David Edmundson wrote: > That applies a patch to s

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37921 --- What's up with this one, is it already shipped? - Mark Kretsch