Re: Review Request 114321: Fix timezone saving in System Settings -> Date & Time

2013-12-05 Thread John Layt
> On Dec. 5, 2013, 11:52 p.m., Martin Klapetek wrote: > > Note that Debian-based systems actually do copy the file rather than > > symlink - main reason being that if you use a symlink and your /usr is > > mounted on a separate partition, anything that starts before /usr gets > > mounted will

Re: Review Request 114321: Fix timezone saving in System Settings -> Date & Time

2013-12-05 Thread Jan Kundrát
> On Dec. 5, 2013, 11:52 p.m., Martin Klapetek wrote: > > Note that Debian-based systems actually do copy the file rather than > > symlink - main reason being that if you use a symlink and your /usr is > > mounted on a separate partition, anything that starts before /usr gets > > mounted will

Re: Review Request 114321: Fix timezone saving in System Settings -> Date & Time

2013-12-05 Thread John Layt
> On Dec. 5, 2013, 11:52 p.m., Martin Klapetek wrote: > > Note that Debian-based systems actually do copy the file rather than > > symlink - main reason being that if you use a symlink and your /usr is > > mounted on a separate partition, anything that starts before /usr gets > > mounted will

Re: Review Request 114321: Fix timezone saving in System Settings -> Date & Time

2013-12-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114321/#review45241 --- kcontrol/dateandtime/helper.cpp

Re: Review Request 114321: Fix timezone saving in System Settings -> Date & Time

2013-12-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114321/#review45240 --- Note that Debian-based systems actually do copy the file rather

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Dec. 5, 2013, 11:44 p.m.) Review request for KDE Runtime and KDE

Review Request 114321: Fix timezone saving in System Settings -> Date & Time

2013-12-05 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114321/ --- Review request for kde-workspace. Bugs: 159171 and 323511 http://bugs.

Re: Review Request 114314: Fix traceback in Python runner plugins

2013-12-05 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114314/#review45228 --- Ship it! Ship It! - Luca Beltrame On Dec. 5, 2013, 11:11 a.

Review Request 114314: Fix traceback in Python runner plugins

2013-12-05 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114314/ --- Review request for kde-workspace and KDE Bindings. Bugs: https://bugs.laun

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-05 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/ --- (Updated Dec. 5, 2013, 10:14 a.m.) Status -- This change has been mar

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45167 --- This review has been submitted with commit 3ab6ca57de19ed1559a

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-05 Thread Harald Sitter
> On Dec. 5, 2013, 12:23 a.m., Pino Toscano wrote: > > ksplash/ksplashqml/SplashApp.cpp, lines 148-150 > > > > > > What about just calling > > ::exit(2) > > to reach the stdlib function, avoiding the exi