Re: Using Gerrit for code review in KDE

2014-09-14 Thread Jan Kundrát
On Saturday, 13 September 2014 23:29:55 CEST, David Edmundson wrote: I think a good example is your patch today (and pretending you're not a maintainer). There was a single typo in a commit message. I wanted it fixing, but I don't want to have to have to review that whole thing again (in

Re: Using Gerrit for code review in KDE

2014-09-14 Thread Jan Kundrát
On Saturday, 13 September 2014 20:40:27 CEST, Kevin Krammer wrote: As for submit, that IMHO should at least also be available to the review request owner. Does anyone see advantages of having submit restricted at all once the necessary approval has been achieved? I made a mistake when

Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

2014-09-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository:

Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

2014-09-14 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114956/ --- (Updated Sept. 14, 2014, 4:57 p.m.) Status -- This change has been

replacement for KDialog::[save|restore]DialogSize?

2014-09-14 Thread Aaron J. Seigo
hi.. what is the new idiom for KDialog::[save|restore]DialogSize when moving to QDialog? i couldn't find anything in the porting notes or in the porting scripts. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part.

window titles with modified status

2014-09-14 Thread Aaron J. Seigo
hi.. KDialog::makeStandardCaption used to provide standardized support for creating window titles with a modified status. is there a replacement for this in frameworks 5? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part.

Re: replacement for KDialog::[save|restore]DialogSize?

2014-09-14 Thread Thomas Lübking
On Sonntag, 14. September 2014 19:16:35 CEST, Aaron J. Seigo wrote: hi.. what is the new idiom for KDialog::[save|restore]DialogSize when moving to QDialog? i couldn't find anything in the porting notes or in the porting scripts. KWindowConfig::[save|restore]WindowSize, i'd say. Dialog

Re: replacement for KDialog::[save|restore]DialogSize?

2014-09-14 Thread Aaron J. Seigo
On Sunday, September 14, 2014 19.49:42 Thomas Lübking wrote: On Sonntag, 14. September 2014 19:16:35 CEST, Aaron J. Seigo wrote: hi.. what is the new idiom for KDialog::[save|restore]DialogSize when moving to QDialog? i couldn't find anything in the porting notes or in the porting

Re: replacement for KDialog::[save|restore]DialogSize?

2014-09-14 Thread Thomas Lübking
On Sonntag, 14. September 2014 21:22:38 CEST, Aaron J. Seigo wrote: thanks. it's a little quirky: it doesn't work from the ctor of a QDialog subclass... You'll have to ensure that a) there's a QWindow (call QWidget::winId()) b) the eventloop is up (once the Qt bug is fixed - until then copying

Re: window titles with modified status

2014-09-14 Thread David Edmundson
​http://qt-project.org/doc/qt-5/qwidget.html#windowModified-prop

Re: Retiring and testament

2014-09-14 Thread Alex Merry
On 2014-09-09 16:41, Kevin Ottens wrote: Now, let's get to the subject of this email: effective immediately I will be stepping back from KDE Frameworks to refocus my energy elsewhere in KDE. Some of you probably saw this coming as I was already less active over the past few weeks. Thank you

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: kdeui/util/kcrash.cpp, line 316 https://git.reviewboard.kde.org/r/119497/diff/1/?file=293441#file293441line316 is libdispatch OSX only or is it also used on FreeBSD? The question (more to Michael ;-) is whether

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/ --- (Updated Sept. 15, 2014, 1:39 a.m.) Review request for KDE Software on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-09-14 Thread Ian Wadham
On July 28, 2014, 12:57 a.m., Ian Wadham wrote: kinit/kinit.cpp, line 119 https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line119 The real issue is on this line. I do not know how MAC_DISPLAY got into the act, but clearly it has not been tested recently, if

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-14 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/ --- (Updated Sept. 15, 2014, 1:59 a.m.) Review request for KDE Software on

Review Request 120210: kdoctools: style images more elegantly

2014-09-14 Thread T.C. Hollingsworth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120210/ --- Review request for Documentation, kdelibs and Luigi Toscano. Repository: