Am Dienstag, 16. September 2014, 00.52:28 schrieb Albert Astals Cid:
Morning
Thanks a lot for bringing this forward. IMHO it's a very important topic and
future communication channel with our users but I think as well that it's a
multi-year thing before we can earn the first fruits. So let's
On Sept. 16, 2014, 3:39 p.m., David Faure wrote:
better idea, testing for KDiskFreeSpaceInfo's success.
http://www.davidfaure.fr/2014/copyjob.cpp.diff
That works as well.
- Dawit
---
This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/
---
(Updated Sept. 17, 2014, 12:55 p.m.)
Review request for kdelibs and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/
---
(Updated Sept. 17, 2014, 7:48 p.m.)
Review request for KDE Software on
On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote:
kdeui/actions/kaction.cpp, line 149
https://git.reviewboard.kde.org/r/120149/diff/2/?file=312029#file312029line149
what if
KAction *foo = new KAction(this);
foo-setText(Foo);
- you rather want to monitor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120149/#review66764
---
Ship it!
Two general notes:
- please respect the kdelibs
On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote:
Two general notes:
- please respect the kdelibs coding style, for example removing the extra
spaces in instructions
- please remove the extra kDebug
Oops, I accidentally checked Ship it!, while this is totally not the case
(rather, as
El Dimecres, 17 de setembre de 2014, a les 10:02:08, Mario Fux va escriure:
Am Dienstag, 16. September 2014, 00.52:28 schrieb Albert Astals Cid:
Morning
Thanks a lot for bringing this forward. IMHO it's a very important topic and
future communication channel with our users but I think as
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110563/
---
(Updated Sept. 17, 2014, 7:36 nachm.)
Status
--
This change has
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review66430
---
Interesting, didn't know about this posix restriction (a bit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/#review66775
---
Ship it!
I like this patch :-)
Well, maybe we could even
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/notifications/kstatusnotifieritem.cpp, lines 728-730
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312870#file312870line728
What is this used for?
If it is not used, please remove it, otherwise just include it
On Sept. 17, 2014, 7:39 nachm., David Faure wrote:
Interesting, didn't know about this posix restriction (a bit inconsistent
imho, the readonly dir vs readonly file difference).
The ro flag only guarantees integrity, not presence.
The absent write permission of a directory esp. protects
On Sept. 17, 2014, 7:39 p.m., David Faure wrote:
Interesting, didn't know about this posix restriction (a bit inconsistent
imho, the readonly dir vs readonly file difference).
Thomas Lübking wrote:
The ro flag only guarantees integrity, not presence.
The absent write
On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote:
kdeui/actions/kaction.cpp, lines 150-179
https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150
The whole setTextWithCorrectMenuRole is totally broken from an i18n
point of view:
- we don't use Qt's
On Sept. 17, 2014, 7:49 p.m., David Faure wrote:
I like this patch :-)
Well, maybe we could even get rid of the fsType checks?
I was going to suggest the same thing. For our purposes here, we do not care if
the filesystem type is identified. We only care about whether or not the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120182/
---
(Updated Sept. 18, 2014, 3:52 a.m.)
Review request for kdelibs and David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119498/#review66801
---
Please would someone give this a Ship It, or should I do it
22 matches
Mail list logo
