Re: Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

2016-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129208/#review100139 --- Ship it! Ship It! - David Faure On Oct. 18, 2016,

Jenkins-kde-ci: kdelibs KDE-4.14 stable-qt4 » Linux,gcc - Build # 57 - Still Unstable!

2016-10-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20stable-qt4/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Oct 2016 12:49:16 + Build duration: 36 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 56 - Fixed!

2016-10-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Oct 2016 12:49:16 + Build duration: 32 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs KDE-4.14 latest-qt4 » Linux,gcc - Build # 56 - Fixed!

2016-10-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs%20KDE-4.14%20latest-qt4/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Oct 2016 12:49:16 + Build duration: 32 min CHANGE SET Revision

Re: Review Request 129219: Fix gcc 6.2 compile error.

2016-10-19 Thread Albert Astals Cid
> On Oct. 19, 2016, 9 a.m., Albert Astals Cid wrote: > > I almost sure you're using an old kdelibs > > > > https://github.com/KDE/kdelibs/commit/1e9ba7d00bb870c7f5b7d2af2ccd31799e1b1910 > > should fix that problem > > Ralf Habacker wrote: > Thanks for this pointer. Taking a look at the

Re: Review Request 129119: Fix HAVE_TRUNC cmake check

2016-10-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/ --- (Updated Oct. 19, 2016, 12:48 p.m.) Status -- This change has been

Re: Review Request 129119: Fix HAVE_TRUNC cmake check

2016-10-19 Thread Ralf Habacker
> On Okt. 19, 2016, 12:12 nachm., Ralf Habacker wrote: > > I had the same issue with gcc 6.2. I can confirm that the patch fixes the > > issue. I would have pushed the related commit into kdelibs repo, but got rejected with the error 'remote: Audit failure - Commit

Re: Review Request 129119: Fix HAVE_TRUNC cmake check

2016-10-19 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/#review100129 --- I had the same issue with gcc 6.2. I can confirm that the

Re: Review Request 129219: Fix gcc 6.2 compile error.

2016-10-19 Thread Ralf Habacker
> On Okt. 19, 2016, 11 vorm., Albert Astals Cid wrote: > > I almost sure you're using an old kdelibs > > > > https://github.com/KDE/kdelibs/commit/1e9ba7d00bb870c7f5b7d2af2ccd31799e1b1910 > > should fix that problem Thanks for this pointer. Taking a look at the implementation: SHOW_ALL looks

Re: Review Request 129219: Fix gcc 6.2 compile error.

2016-10-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129219/#review100130 --- I almost sure you're using an old kdelibs

Review Request 129219: Fix gcc 6.2 compile error.

2016-10-19 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129219/ --- Review request for kdelibs. Repository: kdelibs Description ---

Re: Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

2016-10-19 Thread Gerhard Gappmeier
> On Oct. 17, 2016, 12:13 p.m., Aleix Pol Gonzalez wrote: > > I'm not sure it's a very good idea to introduce behavior changes in kdelibs > > 4. Why can't you use kde-open from kf5? > > Gerhard Gappmeier wrote: > Because I'm running KDE4 on many machines and want this bug fixed. It's >