Re: Review Request 129644: i10n: update Czech Republic to Czechia

> On Dec. 13, 2016, 3:23 p.m., Luigi Toscano wrote: > > Ahoj, out of curiosity: this is for kdelibs4 applications, how was handled > > in the sources used by Qt5 applications? I don't think we have those > > information in Frameworks anymore. > > > > It would maybe worth to have consistency

Re: Review Request 129208: Fix KUrl::isRelativeUrl to allow all RFC3986 characters in scheme.

changes in kdelibs 4. Why can't you use kde-open from kf5? - Aleix Pol Gonzalez On Oct. 17, 2016, 12:18 p.m., Gerhard Gappmeier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 129119: Fix HAVE_TRUNC cmake check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/#review100057 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 7

Re: Review Request 128909: initial, minimal support for OS X

tps://git.reviewboard.kde.org/r/128909/#comment66908> Wrong indentation processui/ReniceDlg.cpp (line 79) <https://git.reviewboard.kde.org/r/128909/#comment66909> Wrong indentation. Also isn't it possible to query the backend or something? - Aleix Pol Gonzalez On Sept. 22, 2016, 4:5

Re: Review Request 128909: initial, minimal support for OS X

> On Sept. 17, 2016, 9:52 p.m., René J.V. Bertin wrote: > > processui/ReniceDlg.cpp, lines 78-87 > > > > > > I've actually managed to get ksysguardprocesslist_helper to work with a > > patched libdbus and a hack

Re: Review Request 128909: initial, minimal support for OS X

tps://git.reviewboard.kde.org/r/128909/#comment66802> drop trailing space - Aleix Pol Gonzalez On Sept. 15, 2016, 2:47 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 128909: initial, minimal support for OS X

> On Sept. 15, 2016, 1:29 a.m., Aleix Pol Gonzalez wrote: > > processcore/helper.cpp, line 133 > > <https://git.reviewboard.kde.org/r/128909/diff/2/?file=476882#file476882line133> > > > > `KAUTH_HELPER_MAIN` doesn't work on OS X? > > René J.V. Be

Re: Review Request 128909: initial, minimal support for OS X

(line 133) <https://git.reviewboard.kde.org/r/128909/#comment66774> `KAUTH_HELPER_MAIN` doesn't work on OS X? - Aleix Pol Gonzalez On Sept. 14, 2016, 9:37 p.m., René J.V. Bertin wrote: > > --- > This is an automatically g

Re: Review Request 128637: Remove obsolete kdepasswd docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128637/#review98257 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 9, 2016

Re: Review Request 127924: Warn about KDateTimeParser::parseDateUnicode not being implemented

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127924/#review95479 --- +1 - Aleix Pol Gonzalez On May 15, 2016, 10:44 a.m

Re: Review Request 127823: Allow building without strigi on Linux

> On May 3, 2016, 2:58 p.m., Aleix Pol Gonzalez wrote: > > Why touch the `if(WIN32)` though? If needed, just make it optional on all > > platforms. > > Antonio Rojas wrote: > That's what I'm doing... Currently it's only optional on WIN32, I'm > changing i

Re: Review Request 127823: Allow building without strigi on Linux

it optional on all platforms. - Aleix Pol Gonzalez On May 3, 2016, 2:06 p.m., Antonio Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127515: Port away keditbookmarks from KCmdLine* and K4AboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127515/#review94101 --- +1 LGTM - Aleix Pol Gonzalez On March 28, 2016, 6:06 p.m

Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

tps://git.reviewboard.kde.org/r/127264/#comment63484> Without the conditionals, the code would work just as well. - Aleix Pol Gonzalez On March 3, 2016, 1:58 p.m., Rohan Garg wrote: > > --- > This is an automatically generated e

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

... - Aleix Pol Gonzalez On Jan. 13, 2016, 7:03 a.m., Andrey Bondrov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

/cursorthemesmodel.h (line 3) <https://git.reviewboard.kde.org/r/126704/#comment62216> Fix copyright to your name and this year. src/cursorthemesmodel.cpp (line 3) <https://git.reviewboard.kde.org/r/126704/#comment62217> Copyright - Aleix Pol Gonzalez On Jan. 16, 2016, 5:14

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

a CursorThemesModel inheriting IconThemesModel that overrides some methods (you can add virtuals). Otherwise we're adding weirdly specific logic. Also I'd say it would be really good to be able to show some preview of the theme somehow, otherwise it's hard to tell them apart. - Aleix Pol Gonzalez

Re: Review Request 126704: [kde-gtk-config] Implement changing cursor theme for GTK applications

tps://git.reviewboard.kde.org/r/126704/#comment62152> No-op change. src/iconthemesmodel.cpp (line 98) <https://git.reviewboard.kde.org/r/126704/#comment62153> Now that you have the CursorsThemeModel that shouldn't be needed anymore. If it still is, add a virtual. - Aleix Pol Gonzalez

Re: Review Request 125613: Race condition and error notification loss in ListJob

ab7d96 in QApplication::notify (this=0x7fffde80, receiver=0x7be360, e=0x7fffd8f0) at /home/kde-devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3498 ``` - Aleix Pol Gonzalez On Oct. 24, 2015, 7:54 p.m., Alberto Jiménez Ruiz wrote: > > ---

Re: Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125476/#review86204 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Oct. 1

Re: Review Request 123437: FinKexiv2: Use FindPkgConfig instead of UsePkgConfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123437/#review82594 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 13, 2015

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

On May 23, 2015, 2:23 a.m., Aleix Pol Gonzalez wrote: Hm.. Builds here. Also builds in build.kde.org... https://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ :/ Jeremy Whiting wrote: I'm not sure why, but I did test a few times before making

Re: Review Request 123881: Add KONSOLEPRIVATE_EXPORT to HistoryScroll since it's hasScroll method is needed.

://build.kde.org/job/konsole%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ :/ - Aleix Pol Gonzalez On May 22, 2015, 9:49 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123458: Improvements to the handling of font weights and styles

On April 22, 2015, 12:40 a.m., Luigi Toscano wrote: I think this should go to Qt (I think it's quite difficult they will accept it, as Qt4 is in hard freeze mode), and they will probably ask to see if it applies to Qt5 as well. We just mirror Qt... not sure how to handle this.

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

On March 17, 2015, 6:05 p.m., Christophe Giboudeaux wrote: src/plugins/hunspell/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line9 endif() Eugene Shalygin wrote: Ping? He means you shouldn't put anything inside endif()

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

, that's quite a different thing. Maybe it should be a runtime check? - Aleix Pol Gonzalez On March 17, 2015, 2:09 p.m., Eugene Shalygin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 122556: Bump Qt version to 5.4

On Feb. 13, 2015, 9:41 a.m., Martin Gräßlin wrote: AFAIK our CI system doesn't support Qt 5.4 yet. I think we should first ensure the CI system is prepared for building with the new dependency. Albert Astals Cid wrote: It does

Re: Review Request 122534: [konq-plugins] fsview: Add missing include(ECMMarkAsTest)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122534/#review75909 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 12, 2015

Re: Review Request 122471: Enable Compilation of about Protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122471/#review75619 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 7, 2015

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

/122475/#comment52312 I would add an: else { qWarning() couldn't create a valid url for str; } Maybe it should even return, it's not nice trying something, getting the application running but not doing what you expected it to. - Aleix Pol Gonzalez On Feb. 8, 2015, 4:46 a.m

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

/121831/#comment51593 Maybe you want to prefix the attribute variables with m_ then? - Aleix Pol Gonzalez On Jan. 19, 2015, 7:17 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

(ECM) as well? - Aleix Pol Gonzalez On Nov. 17, 2014, 3:20 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147

Re: Review Request 121076: Do not require KF5::Su on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/#review70147 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014

Re: Review Request 121078: Fix exports.

a step forward towards a ported dolphin. I'm saying shipit because I've ended having to do that in many projects already. Thanks! - Aleix Pol Gonzalez On Nov. 8, 2014, 10:25 p.m., Andrius da Costa Ribas wrote: --- This is an automatically

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70149 --- Shouldn't it be actually implemented then? - Aleix Pol

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

/CMakeLists.txt https://git.reviewboard.kde.org/r/121083/#comment49079 remove trailing spaces. - Aleix Pol Gonzalez On Nov. 9, 2014, 2:23 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 120652: Remove kdemacros.h and use generate_export_header for interfaces folder.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120652/#review68714 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 19, 2014

Re: Review Request 120554: Initial frameworks port of kompare

are regarding qDebug usage. I would suggest just to move it into a frameworks branch as well. +1 all in all. - Aleix Pol Gonzalez On Oct. 13, 2014, 11:46 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 120535: attica: Add const to getter methods.

On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

. - Aleix Pol Gonzalez On Aug. 3, 2014, 7:13 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63721 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Aug

Re: Review Request 119446: Add a simple test for meinproc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119446/#review63103 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 24, 2014

Re: Review Request 119447: meinproc: check both result of parsing and validation

checking :) - Aleix Pol Gonzalez On July 24, 2014, 12:10 a.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119447

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

/119243/#comment43221 I don't know why you did that, but it doesn't look good. Other than that it looks ok. Please update the patch though. - Aleix Pol Gonzalez On July 12, 2014, 9:55 a.m., Marko Käning wrote

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

doing, so +1 from me. Your patch is applied on kdelibs/kio. kdelibs has been split into different frameworks, so you want to do it on the kio repository. - Aleix Pol Gonzalez On April 3, 2014, 2:29 a.m., Simeon Bird wrote

Re: Review Request 117090: add version to libmolletnetwork

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117090/#review54522 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 26, 2014

Re: Review Request 117096: rename khelpcenter to khelpcenter5 for coinstallability

is usually in charge for showing the help of applications. Then there's also kcmutils, in kcmultidialog.cpp, that also calls it. I didn't see other users. - Aleix Pol Gonzalez On March 26, 2014, 5:57 p.m., Jonathan Riddell wrote

Re: Review Request 117095: rename kdebugdialog to kdebugdialog5 for coinstallability

? - Aleix Pol Gonzalez On March 26, 2014, 5:23 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117095

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

to be this way. - Aleix Pol Gonzalez On Feb. 13, 2014, 10:14 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

On Feb. 19, 2014, 10:06 a.m., Aleix Pol Gonzalez wrote: src/knotificationmanager.cpp, line 180 https://git.reviewboard.kde.org/r/115695/diff/3/?file=243841#file243841line180 ? Martin Klapetek wrote: Yet once again the description xD - it's full of ... FIXMEs to indicate

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

anybody's going to read this output ever... - Aleix Pol Gonzalez On Jan. 28, 2014, 1 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351

Re: Review Request 114623: kjs: Implement es6 Math.fround

On Dec. 24, 2013, 1:13 p.m., Martin Tobias Holmedahl Sandsmark wrote: what a silly function, but looks okay to me. Shouldn't this go to KF5? Also kdelibs is feature frozen... - Aleix --- This is an automatically generated e-mail. To

Re: Review Request 114717: Language detection in Sonnet

/114717/#comment33300 Does this really need to be hardcoded here? O.o Thanks for working on this! - Aleix Pol Gonzalez On Dec. 29, 2013, 4:49 a.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

to remove this comment- kioslave/smb/kio_smb_internal.cpp http://git.reviewboard.kde.org/r/112463/#comment32427 Does it really need QDir::separator()? It seems to me like everything should be '/'. - Aleix Pol Gonzalez On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote: kioslave/smb/kio_smb_auth.cpp, line 76 http://git.reviewboard.kde.org/r/112463/diff/3/?file=222937#file222937line76 A xD Maybe we can just remove this one? Mark Gaiser wrote: Just the A

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45520 --- Ship it! - Aleix Pol Gonzalez On Dec. 10, 2013, 6:51 p.m

Re: Review Request 113833: fix include file in kio

/tcpslavebase.h #include ../../kio/jobclasses.h - Aleix Pol Gonzalez On Nov. 13, 2013, 11:50 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113833

Re: Review Request 113846: fix kicontheme::list

Pol Gonzalez On Nov. 13, 2013, 5:33 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846

Re: Review Request 113218: Enable translation functions for js script loaded through Kross

. - Aleix Pol Gonzalez On Oct. 12, 2013, 3:09 p.m., Luigi Toscano wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113218

Re: Review Request 113194: port away from KIcon in libs/taskmanager

according to KDE5Porting.html - Aleix Pol Gonzalez On Oct. 10, 2013, 9:42 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113194

Re: Review Request 113153: Deprecate KFileMetaDataWidget and KFileMetaDataConfigurationWidget

. :) Maybe you should put a note on KDE5Porting.hml - Aleix Pol Gonzalez On Oct. 7, 2013, 5:01 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113153

Re: Review Request 112367: Include the icon's theme in the cache key

the cache whenever the theme is changed. The cache is not useful anymore after a theme change. - Aleix Pol Gonzalez On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: kdeui/util/kglobalsettings.cpp, line 308 http://git.reviewboard.kde.org/r/71/diff/1/?file=165092#file165092line308 These are the colors for the window titlbar (with ambiguous function names, though), the default for

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

behavioral change for users of Laptop, Plastik, BII and some legacy decorations (you still /can/ compile Quartz and Keramik and what they all were called) and pot. some distro specific decorations. Aleix Pol Gonzalez wrote: Are you sure these are being used? because I searched for uses

Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111000/#review34315 --- +1 :) sounds interesting! - Aleix Pol Gonzalez On June 13

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

On May 23, 2013, 9:16 a.m., Patrick von Reth wrote: Sorry for the missing feedback we already apply your patch locally and its already part of our release so please ship it. BIG THANKS Michel Ludwig wrote: Ok. As I haven't done any commits to kdelibs in a while, does anybody

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

versions. Thanks, Aleix Pol Gonzalez

Review Request 109404: Give more precedence to qmake executable names that specify the version

(KDE4) - Configuring such a project returns the correct versions. Thanks, Aleix Pol Gonzalez

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

the correct versions. Thanks, Aleix Pol Gonzalez

Re: Review Request 109404: Give more precedence to qmake executable names that specify the version

versions. Thanks, Aleix Pol Gonzalez

Re: Review Request 107716: Fix generating kconfig skeletons with UrlList fields that have a default value

/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Re: Review Request 107791: move Sonnet out of KDEUI, port away from KDE classes.

? Maybe you forgot some git mv? - Aleix Pol Gonzalez On Feb. 10, 2013, 8:40 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107791

Review Request: Don't add qml elements twice to the scene, reduce warnings

. Thanks, Aleix Pol Gonzalez

Re: Review Request: Fix generating kconfig skeletons with UrlList fields that have a default value

. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107716/#review23658 --- On Dec. 14, 2012, 1:17 p.m., Aleix Pol Gonzalez wrote

Review Request: Fix generating kconfig skeletons with UrlList fields that have a default value

this context Diffs - kdecore/kconfig_compiler/kconfig_compiler.cpp 4203d30 Diff: http://git.reviewboard.kde.org/r/107716/diff/ Testing --- Thanks, Aleix Pol Gonzalez

Review Request: properly pass the NOGUI flag

uses NOGUI there. Thanks, Aleix Pol Gonzalez

Re: Review Request: Add cmake config for kdeclarative library.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review12971 --- bump. what's the status of this? - Aleix Pol Gonzalez