Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-19 Thread Andrius da Costa Ribas
On Nov. 10, 2014, 9:41 p.m., David Faure wrote: lib/konq/src/konq_historyentry.h, line 57 https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57 const ref, no? Andrius da Costa Ribas wrote: before I try to fix the pending issues: what are we going

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas
-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/#review75951 --- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121079/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-04 Thread Andrius da Costa Ribas
--- On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080

Re: Review Request 121081: QT_WA

2015-02-12 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121081/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

2015-02-12 Thread Andrius da Costa Ribas
--- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
b8877a0 liboxygen/CMakeLists.txt 69b7bd2 Diff: https://git.reviewboard.kde.org/r/121083/diff/ Testing --- Builds with msvc 2013 64bit Thanks, Andrius da Costa Ribas

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
--- On Nov. 21, 2014, 10:47 p.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-19 Thread Andrius da Costa Ribas
and weird UI). Thanks, Andrius da Costa Ribas

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Andrius da Costa Ribas
(missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Andrius da Costa Ribas
/ Testing --- Builds with msvc 2013 64bit Thanks, Andrius da Costa Ribas

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas
Diff: https://git.reviewboard.kde.org/r/121076/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121077: Check before using -Wno-deprecated-declarations.

2014-11-08 Thread Andrius da Costa Ribas
today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121078: Fix exports.

2014-11-08 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/121078/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121079: Fix building dolphin tests on MSVC

2014-11-08 Thread Andrius da Costa Ribas
this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-08 Thread Andrius da Costa Ribas
(MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 121081: QT_WA

2014-11-08 Thread Andrius da Costa Ribas
other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas

Review Request 114984: Fix build on MinGW with newer Windows SDK's strsafe.h

2014-01-12 Thread Andrius da Costa Ribas
work fine. No errors when building with MSVC either. Thanks, Andrius da Costa Ribas

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-30 Thread Andrius da Costa Ribas
a MinGW setup to check. Not tested on *nix, but the original patch was not changed except for iterating order in the common part and namespacing. File Attachments screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-11-08 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112009/#review43272 --- ping? may I ship it? - Andrius da Costa Ribas On Aug. 17

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-17 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-17 Thread Andrius da Costa Ribas
of the parentheses right? Andrius da Costa Ribas wrote: I didn't get this one, what can be moved out? Patrick Spendrin wrote: This line seems to be in both parts of the if(WIN32) clause, so either it is wrong? or you can move it out of the parentheses? set

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-11 Thread Andrius da Costa Ribas
to check. Not tested on *nix, but the original patch was not changed except for iterating order in the common part and namespacing. File Attachments screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas

Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
in the common part and namespacing. File Attachments screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
except for iterating order in the common part and namespacing. File Attachments screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
except for iterating order in the common part and namespacing. File Attachments screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-10 Thread Andrius da Costa Ribas
except for iterating order in the common part and namespacing. File Attachments screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png Thanks, Andrius da Costa Ribas

Google Drive KIOSlave

2012-09-27 Thread Andrius da Costa Ribas
Hello, I'm not sure if this is the correct place to ask but I've started writing a google drive kioslave and reached some particularities of this filesystem that I'd like some suggestions: 1. Google drive has its own trash: - for this one I'm thinking about making two different protocols

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Andrius da Costa Ribas
add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with RC.exe when I try to add a kde4_add_app_icon. fatal error RC1106: invalid option: -EHsc any hint with that? -- Andrius. 2012/7/26 Andrius da Costa Ribas andrius...@gmail.com Hello, In src/systemexception.h: return

Re: Compiler version

2012-07-01 Thread Andrius da Costa Ribas
Windows emerge tool currently uses gcc 4.6.4 for 64-bit and either gcc 4.7 or msvc 2010 for 32-bit, so for gcc builds there should be no problem, I'm not sure about msvc. -- Andrius. 2012/7/1 Martin Gräßlin mgraess...@kde.org Am 30.06.2012 17:31, schrieb Heinz Wiesinger: However, the point

Re: Review Request: Rename Samba Shares to Windows Shares (SMB)

2012-06-22 Thread Andrius da Costa Ribas
On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: I don't really know if we should do this.. I do understand why you want to rename it. From a user point of view the user probably wants to either access windows shares or make shares accessible for windows. Either way, it's done

Re: Review Request: New KDE Macro for to wrap the noreturn attribute

2012-04-27 Thread Andrius da Costa Ribas
return (tested using mingw-w32, not mingw.org) - Andrius da Costa Ribas On Jan. 31, 2012, 8:58 p.m., Allen Winter wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103832

Re: Pairs going to KDE Edu

2012-04-19 Thread Andrius da Costa Ribas
Hello, Please find attached suggested patches to fix/improve Windows build. (ps: I'm not in kde-edu mailing list, so this e-mail will probably be blocked there). Thanks, Andrius. 2012/4/17 Albert Astals Cid aa...@kde.org El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure:

Re: Review Request: [KDE/Windows] Do not set cursorFlashTime, but respect Control Panel setting

2012-04-02 Thread Andrius da Costa Ribas
, but I think the same should apply to DoubleClickInterval property. - Andrius da Costa Ribas On Aug. 12, 2011, 12:39 a.m., Christoph Feck wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-05 Thread Andrius da Costa Ribas
work in a frozen window]. Screenshots --- Tabs! http://git.reviewboard.kde.org/r/102758/s/281/ More Tabs! http://git.reviewboard.kde.org/r/102758/s/282/ Too many tabs! http://git.reviewboard.kde.org/r/102758/s/283/ Thanks, Andrius da Costa Ribas

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-05 Thread Andrius da Costa Ribas
someone to implement and at least Mozilla already showed interest in adding support if we add that. Andrius da Costa Ribas wrote: My thoughts: - I did an first experiment with dolphin only, but yes, we all agree this might be inside some sort of library. - I don't think KTabWidget

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-04 Thread Andrius da Costa Ribas
--- On Oct. 3, 2011, 1:25 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102758

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-04 Thread Andrius da Costa Ribas
://git.reviewboard.kde.org/r/102758/#comment6212 Would it worth using KIO's ThumbCreator instead? - Andrius da Costa Ribas On Oct. 3, 2011, 1:25 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: http