Re: KDE review for KWeatherCore

Hi Han, let's have this discussion public on kde-core-devel and kde-framworks, so other can contribute. On Sat, Jan 2, 2021 at 1:29 PM hanyoung wrote: > > Hi Dominik, > > Thank you for your time. This is my first time writing a library, I tried my > best by looking > at existing KDE frameworks

Re: KDE review for KWeatherCore

Hi Han, just having a quick glance at the code, and I feel like there is a lot of polishing missing. I'll give some examples, but this is by no means a complete review, and I'll not comment on technical aspects at all, since this is not the domain of my expertise. - #pragma once: It's used in

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

Hi Steve, Stephen Kelly schrieb am Mo., 30. Dez. 2019, 11:57: > > On 30/12/2019 10:55, Christoph Cullmann wrote: > > Hi, > > > >>> With my KTextEditor hat on: KF6:TextDocument implies somehow a link > >>> to QTextDocument or KF6:TextEditor, which both is incorrect, right? > >> > >>

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

Hi, Stephen Kelly schrieb am So., 29. Dez. 2019, 15:03: > > On 28/12/2019 23:30, Friedrich W. H. Kossebau wrote: > > Why are you proposing to do a step back instead to the old state, which > > everyone including you considered not that satisfying? > > Because it's a temporary situation. We

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

57 CET schrieb Volker Krause: > > > > On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > > > > > Hi all, > > > > > > > > > > in any case, maybe the discussed points should go to the KF6 > > > > > workboard?

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

Hi all, in any case, maybe the discussed points should go to the KF6 workboard? https://phabricator.kde.org/project/view/310/ I indeed believe that consistency in the KF5 world is an important feature, so Friedrich does have a point here. Other framework additions had to adapt as well (what

Re: ELF Dissector in kdereview

Hi Volker, may I suggest that you also blog about this at some point in time? :-) I know this is additional work (sorry), but it helps a lot visibility wise. This blog can then be posted at reddit/r/linux et al... Best regards Dominik On Sat, Sep 28, 2019 at 1:03 PM Volker Krause wrote: > Hi,

Re: Proposing Quick Charts as a new framework

Hi, On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra wrote: > On 06-09-2019 02:49, Aleix Pol wrote: > > On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra > > wrote: > >> > >> On 02-09-2019 19:26, Luigi Toscano wrote: > >> > Arjen Hiemstra ha scritto: > [...] > >> That's actually a good point,

Re: CI system maintainability

Kevin Ottens schrieb am Do., 28. März 2019, 09:29: > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

Re: Python bindings using cppyy (was: An update on Python bindings)

... wasn't there also some python related work by Stefan? Or is that unrelated? Greetings Dominik Am Mo., 5. Nov. 2018, 16:20 hat Shaheed Haque geschrieben: > I'm afraid that there has been no progress as I am buried in "startup" > mode. I'm not sure when that might change. > > On Mon, 5 Nov

Phabricator: How to get the email address of contributors?

Hi everyone, it just happened to me again, that I want to commit/push a change of someone else (first-time contributor) with the correct --author="x y " data. But Phabricator hides the email address, so I either have to ask via phabricator messages for the email address, which is time consuming,

Re: http://commitfilter.kde.org/ ?

Hi, On Mon, Oct 30, 2017 at 8:38 AM, Ben Cooksley wrote: > On Mon, Oct 30, 2017 at 6:38 PM, Martin Koller wrote: >>> On Sun, Oct 29, 2017 at 9:47 PM, Martin Koller wrote: >>> > Should http://commitfilter.kde.org/ still exist ? >>> > Currently I

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

=1420501=kdeplasma-addons - Dominik Haumann On Feb. 5, 2017, 6:11 p.m., Pascal VITOUX wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

n any case. - Dominik Haumann On Feb. 4, 2017, 12:03 a.m., Pascal VITOUX wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: KDE Frameworks 5.28.0 released

On Tue, Nov 15, 2016 at 2:37 PM, David Faure wrote: > 15th November 2016. KDE today announces the release of KDE Frameworks 5.28.0. > > KDE Frameworks are 70 addon libraries to Qt which provide a wide variety of· > commonly needed functionality in mature, peer reviewed and well

Re: Dropping kdelibs4-based applications in KDE Applications 17.12

On Thu, Nov 10, 2016 at 11:42 PM, Albert Astals Cid wrote: > Hi, my proposal would be to make KDE Applications 17.08 the last release we > accept applications based on kdelibs4, that means people have a year until KDE > Applications 17.12 to port the applications from the list

Re: Required VS compiler

On Wed, Mar 23, 2016 at 7:51 AM, Thomas Friedrichsmeier <thomas.friedrichsme...@ruhr-uni-bochum.de> wrote: > On Mon, 21 Mar 2016 22:07:57 +0100 > Dominik Haumann <dhaum...@kde.org> wrote: [...] >> Therefore, I would like to propose v2015 as required compiler >> an

Fwd: Required VS compiler

Hi all, I installed Qt 5.6.0 and MSVC 2015, and surprisingly Kate including all its dependencies compiled out of the box. I still see QStringLiteral fixes from time to time on the commit mailing list. Given MSVC 2015 Community Edition is available just like v2013, and it seems to work I believe

Re: Open Folder and select file

gt; Cheers, > Emmanuel > > [1] https://www.freedesktop.org/wiki/Specifications/file-manager-interface/ > [2] https://git.reviewboard.kde.org/r/127004/ > > 2016-03-19 21:16 GMT+01:00 Dominik Haumann <dhaum...@kde.org>: >> >> Hi, >> >> in Kate's tab bar

Open Folder and select file

Hi, in Kate's tab bar I would like to implement a context menu action "Open Containing Folder". In KDE, this should open dolphin and preselect the specific file. On Windows, it should open the Explorer and do the same. It seems Qt Creator has some code to do exactly this:

Re: KF5 Porting Notes

On Wed, Jan 6, 2016 at 11:15 PM, Albert Astals Cid wrote: > El Wednesday 06 January 2016, a les 14:56:48, Martin Koller va escriure: >> In the section about KApplication -> QApplication, I find: >> >> Make sure to: >> Call QCoreApplication::setApplicationName() and others ... >> >>

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

->modifiers() == Qt::ControlModifier #ifdef Q_OS_MAC && KGlobalSettings::wheelMouseZooms() #endif ) { // ... That way we at least do not touch the current 4.x code for Linux (which works fine, as I understand), and the workaraound is ok for os X... Would that be ok?

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

On Sept. 23, 2014, 3:01 p.m., Thomas Lübking wrote: Qt cannot distiguish because there's nothing to distinguish - the driver generates synthetic wheel event for the inertia. You can btw. turn that censored off. Seems an issue with inertial scrolling on X11 as well

Re: Using nullptr instead of Q_NULLPTR

I'll only comment on the application side: On Thu, Aug 13, 2015 at 10:46 AM, Sergio Martins iamser...@gmail.com wrote: Btw, what are the c++98/c++11 requirements for applications ? I could only find the page for frameworks. For applications, it's 100% up to the application developer. I'm

Re: RFC: KDE Bugzilla Bugs Expiration

On Saturday 01 August 2015 03:09:14 Kevin Kofler wrote: Christoph Cullmann wrote: I think one of the problems with our current Bugzilla database is that it contains a lot of old bugs and wishs. As the manpower is limited and we sometimes not even keep up with the incoming new bugs,

Re: RFC: KDE Bugzilla Bugs Expiration

Hi, On Fri, Jul 31, 2015 at 10:12 AM, Christoph Cullmann cullm...@absint.com wrote: Hi, I think one of the problems with our current Bugzilla database is that it contains a lot of old bugs and wishs. As the manpower is limited and we sometimes not even keep up with the incoming new bugs,

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual

Re: Sysadmin report on the modernization of our infrastructure

On Wednesday 21 January 2015 22:20:18 Eike Hein wrote: On 01/21/2015 05:12 AM, Ben Cooksley wrote: Hi all, As promised in the earlier thread, i'd like to present the sysadmin report on the state of the infrastructure surrounding our code. As someone on the original git infra team,

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

Apps, Dominik Haumann, Eike Hein, and John Tapsell. Repository: libksysguard Description --- In process.h there are several public fields. I propose to encapsulate the private fields with getter methods. I implemented it exemplary for the fields 'login', 'uid' and 'euid

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

? Before, we just wrote into the varialbes. Now, we use the setters, which also sets 'changes |= Process::Gids;' Is that maybe an issue? I myself don't know the code well enough to see this here. - Dominik Haumann On Jan. 19, 2015, 9:37 nachm., Gregor Mi wrote

Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time

On Jan. 14, 2015, 3:28 p.m., Hrvoje Senjan wrote: ftr, this is a BIC change, so best would be to bump the soversion Because it modified process.h? Why are the members not hidden behind a d-pointer then? Is such a BIC change then allowed at all ? - Dominik

Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time

role. Hm, well yes, it probably doesn't make much sense to copy the text in terms of 3h 2m ago either. So guess this is fine... Or we could even leave it empty, i.e. return QString(). - Dominik Haumann On Jan. 12, 2015, 2:07 p.m., Gregor Mi wrote

Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time

On Jan. 10, 2015, 4:29 p.m., Dominik Haumann wrote: processui/timeutil.h, line 67 https://git.reviewboard.kde.org/r/121717/diff/2/?file=337999#file337999line67 No sure, but maybe in some language we need a proper singular / plural handling here, too? Same

Re: Review Request 121717: libksysguard/processtable: Add new column Relative Start Time

. - Dominik Haumann On Jan. 9, 2015, 10:25 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121717

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

-fix-it-0 (and a followup here: http://kate-editor.org/2012/04/06/crash-through-d-bus-calls/ ) The solution is also to use a QPointer, on the dialog itself (and maybe additionally on the this QObject). In other words, your fix is probably more than just a short-term workaround ;) - Dominik

Re: Review Request 118816: Don't crash konsole when a container destructs

) and the embedded konsole was shown: https://bugs.kde.org/show_bug.cgi?id=331724 I still get the crash when I apply the proposed patch. - Dominik Haumann On June 18, 2014, 5:50 p.m., Jeremy Whiting wrote: --- This is an automatically generated e

Re: Review Request 118816: Don't crash konsole when a container destructs

:236 - Dominik Haumann On June 18, 2014, 7:24 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816

Re: http://techbase.kde.org/Development/Review_Board looks terribly complicated

On Monday, December 16, 2013 00:29:45 Albert Astals Cid wrote: Hi, looking at http://techbase.kde.org/Development/Review_Board I wonder how any of our newbies has ever been able to push a patch to reviewboard if we're suggesting to use that amazing number of hard things to do. Does anyone

Re: KF5 Update Meeting Minutes 2013-w45

On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: snip * sandsmark cleaned up KTextEditorSpellingInterface; I think this was discussed before, but I forgot it again :( The KTextEditor stuff, will it stay in KDELibs for

Re: KF5 Update Meeting Minutes 2013-w45

On Tuesday 05 November 2013 17:20:27 Dominik Haumann wrote: On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: snip * sandsmark cleaned up KTextEditorSpellingInterface; I think this was discussed before, but I forgot

Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11

., Dominik Haumann wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111000/ --- (Updated June 13, 2013, 5:10 p.m.) Review

Re: Review Request 110327: KMessageWidget: Remove decoration icon

On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called

Re: Review Request 110327: KMessageWidget: Remove decoration icon

of this is, however, that this leads to inconsistent ui's. It this is needed, this patch works against this, though. - Dominik Haumann On May 6, 2013, 8:59 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 110327: KMessageWidget: Remove decoration icon

On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called

Re: Review Request 110327: KMessageWidget: Remove decoration icon

On May 7, 2013, 12:50 p.m., Dominik Haumann wrote: The patch itself is fine and most likely does not introduce regressions in terms of misbehavior. Still, is never showing an icon the way to go? Another way to work around this by default would be an additional function called

Re: KSaveFile, QSaveFile, QFile

On Sunday, 24. March 2013 16:25:20 Christoph Cullmann wrote: On Thursday 21 March 2013 19:02:13 David Faure wrote: I'm afraid it's one or the other: * safe code, always a working file available, but hardlinks get splitted up * possibility to corrupt the existing file, but a backup

Re: KSaveFile, QSaveFile, QFile

Hi David, since you pushed QSaveFile to Qt5.1, can you comment on this? Thanks! Dominik On Sunday, March 10, 2013 16:03:06 Dominik Haumann wrote: Hi k-c-d / kwrite-devel, Kate uses KSaveFile in KDE 4.10 to avoid data loss during save operations. According to [1] KSaveFile

KSaveFile, QSaveFile, QFile

Hi k-c-d / kwrite-devel, Kate uses KSaveFile in KDE 4.10 to avoid data loss during save operations. According to [1] KSaveFile will be deprecated in favor of QSaveFile with kf5/Qt5.1. Unfortunately, using KSaveFile introduces quite some regressions in Kate: 1. KSaveFile: Kate/kwrite makes a

Re: Is this a kdelibs regression?

On Tuesday, February 12, 2013 00:56:05 Albert Astals Cid wrote: Someone pointed me to http://quickgit.kde.org/?p=kate.gita=commitdiffh=3adf3cc5473c533f382ae8a48 1e452289a56bab3hp=5addc104e5c181c25a3f16d596602d2755db2128 I have not had time to look at it but fix plugin loading in KDE SC

Re: Finalized proposal for changes to i18n in KF5

On Saturday, December 22, 2012 10:44:22 AM Chusslove Illich wrote: I have written up the headers and Doxygen pages for the Ki18n framework as it should finally look like, available here: http://nedohodnik.net/misc/ki18n-kf5-01/html/index.html

Re: Review Request: Fix sizing of KMessageWidget when shown at startup

that we have in Kate. Your patch simply uses the best height in two places now, instead of just one. I've tested it and it works as expected, so I'd say ship it :-) - Dominik Haumann On Nov. 15, 2012, 12:47 p.m., Aurélien Gâteau wrote

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

? :) - Dominik Haumann On Nov. 15, 2012, 6:40 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332

Review Request: KMainWindow: fix position support in --geometry option

kdelibs build. It's very much appreciated, if someone else can test this. Thanks, Dominik Haumann

Re: Review Request: KMainWindow: fix position support in --geometry option

this. Thanks, Dominik Haumann

Re: Review Request: KMainWindow: fix position support in --geometry option

patch. - Dominik --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20809 --- On Oct. 24, 2012, 5:56 p.m., Dominik Haumann

Re: Review Request: KMainWindow: fix position support in --geometry option

: http://git.reviewboard.kde.org/r/107023/#review20817 --- On Oct. 24, 2012, 9:27 p.m., Dominik Haumann wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: QtScript considered dangerous

-project.org/#change,32359 Many thanks to Kent Hansen for fixing this bug! Right, thanks for taking care of this + keeping us up to date. Greetings, Dominik On Thursday 24 May 2012 10:59:21 Dominik Haumann wrote: Hi Milian, CC: kde-core-devel, as this is really a tough issue

Re: more information in backtraces

On Thursday, 12. July 2012 18:13:22 David Faure wrote: On Thursday 05 July 2012 15:39:33 Dominik Haumann wrote: Here, startPos is a Cursor, but we cannot see its values. It would help tremendously sometimes to know the line/column values. So having startPos=(4, 2) instead of startPos

more information in backtraces

Hi, in Kate, we have a (virtual) Cursor class: class Cursor { // public functions private: int m_line; int m_column }; Unfortunately, in backtraces by Dr. Konqi we only get: #11 0x7f1c85128b2a in KateLayoutCache::updateViewCache (this=0x54db630, startPos=...,

Re: more information in backtraces

On Thursday, July 05, 2012 03:56:16 PM Andreas Pakulat wrote: On Thu, Jul 5, 2012 at 3:39 PM, Dominik Haumann dhaum...@kde.org wrote: Is there any way to provide this feature to get better backtraces by default in Dr. Konqi? It might work with gdb's pretty-printers, but dr. konqi needs

Re: Using userbase for manuals

Hi, On Sunday, July 01, 2012 09:21:08 AM Albert Astals Cid wrote: El Diumenge, 1 de juliol de 2012, a les 08:02:28, Boudewijn Rempt I'm not concerned that users cannot access the help when they are off-line. That's a vanishingly rare situation these days I disagree, as a matter of fact, I

About Writing Documentation in KDE (was: Using userbase for manuals)

Hi everyone, so let's sum up and get back to arguments. 1. Versioning for our KDE SC Releases It was mentioned that a wiki automatically provides versioning. However, what is completely not covered, yet, is the fact that we have different KDE SC releases. There is not 'branching' support for

Re: QtScript considered dangerous

On Friday, 25. May 2012 21:42:50 Stephen Kelly wrote: Christoph Cullmann wrote: Still, a fix for QtScript would be the nicest solution or a port to the new engine provided in Qt5, as I understood, there QtScript is anyway deprecated in favour of the V8 based new variant? Nope. QtScript

Re: QtScript considered dangerous

On Thursday, May 24, 2012 12:57:14 David Faure wrote: On Thursday 24 May 2012 10:59:21 Dominik Haumann wrote: they said they will probably not spent the considerable amount of time in updating the archaic jsc checkout used in QtScript. What about the solution of updating the JSC

Re: QtScript considered dangerous

On Friday, May 25, 2012 11:14:17 Dominik Haumann wrote: So it's probably non-trivial to create this patch (haven't looked into it, though), a dead end as it's Qt4, and unclear, whether such a patch would be accepted at all in the Qt 4.x line, given that the focus is on Qt5 now. And it's

Re: QtScript considered dangerous

On Friday, May 25, 2012 11:55:08 Christoph Cullmann wrote: On Friday, May 25, 2012 11:14:17 Dominik Haumann wrote: And it's unclear, whether a jsc update would fix the issue, btw :-) Still, a fix for QtScript would be the nicest solution or a port to the Right, maybe an increase

Re: QtScript considered dangerous

On Friday, 25. May 2012 12:32:07 Martin Sandsmark wrote: On Fri, May 25, 2012 at 12:03:43PM +0200, Dominik Haumann wrote: Right, maybe an increase of the allowed memory would work, or similar changes... Isn't the problem that the pointer size it uses is too small? As you see, I didn't

Re: QtScript considered dangerous

Hi Milian, CC: kde-core-devel, as this is really a tough issue... there are other applications like Kile that heavily use QtScript for scripting as well, so porting away KatePart from QtScript may solve the issue for KDevelop, the real problem lies (as you say) within QtScript, not Kate. The

Re: Why does KPushButton have a delayedMenu?

On Friday, 6. April 2012 12:53:02 Stephen Kelly wrote: Hi there, I'm trying to figure out why KPushButton has a feature of a 'delayed' menu. Why would applications need that? What problems does it solve? Can the problem be solved in Qt? I think so. The usage of setDelayedMenu is very

Re: Review Request: Dolphin zoom with CTRL+MouseWheel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102490/#review6174 --- dolphin/src/views/dolphinview.cpp

Re: Review Request: Dolphin zoom with CTRL+MouseWheel

On Aug. 30, 2011, 4:55 p.m., Dominik Haumann wrote: dolphin/src/views/dolphinview.cpp, line 691 http://git.reviewboard.kde.org/r/102490/diff/1/?file=33274#file33274line691 Just a maybe: if event-delta() is 8, numDegrees rounds to 0 due to the int conversion. Same

Re: Review Request: Use platform palette and fonts when running on other desktop environments

On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: hmm. but now things are still done twice in a kde session, no? what was wrong with the suggestion to notify qt that it should update stuff? Aurélien Gâteau wrote: createApplicationPalette() is indeed called twice when running

Re: Please, return removed Konqueror feature bug (embedded advanced text editor) in KDE 4.6

On Saturday, 16. April 2011, David Faure wrote: On Friday 15 April 2011, Vladimir Koković wrote: HI, Please, return removed Konqueror feature bug (embedded advanced text editor) in KDE 4.6 !!! Wrong list, and wrong request. We didn't remove such a feature. If it doesn't appear