Hi,
> in the left side filter area, there are tooltips, do you mean others?
Oh, indeed, maybe I was too impatient with my mouse, I can see them now :)
> Do you have a hint how to do this best? Since we should not use
contextProperties anymore, I do not directly see how to avoid a proxy
Hi Kai, many thanks for this very detailed review! For the nitpicks, I did a
first cleanup. Some of the not low hanging fruits regarding UI and features I
added to the backlog items in the Invent project. More details below.
Cheers,
Andreas
On Donnerstag, 3. November 2022 14:58:06 CET Kai Uwe
Hi,
nice work!
Here's some comments, nitpicks, etc on the code (might apply to other
files than the one mentioned, too):
* bootmodel.cpp: I don't think you need to call beginResetModel() when
you populate it in the constructor
* bootmodel.cpp: QAbstractListModel is a flat list with a single
On Sonntag, 23. Oktober 2022 10:34:36 CET Andreas Cord-Landwehr wrote:
> Hi, just a short update: Thank you for the comments! Nearly all of them are
> already fixed. For a very few I created invent.k.o issues instead, because
> they are mostly a maintainability concern and make sense to fix
Hi, just a short update: Thank you for the comments! Nearly all of them are
already fixed. For a very few I created invent.k.o issues instead, because they
are mostly a maintainability concern and make sense to fix together with
planned features (e.g. removal of fixed colors when refactoring
On Mittwoch, 12. Oktober 2022 03:56:03 CEST Aleix Pol wrote:
[...]
> Then I'd recommend to only make it public API when the time comes. :)
>
> +1 to making it optional instead, if it makes your life any better.
> That said, when we've needed this kind of flexibility in the past, we
> have often
On Tue, Oct 11, 2022 at 9:47 PM Andreas Cord-Landwehr
wrote:
>
> On Montag, 10. Oktober 2022 15:34:30 CEST Aleix Pol wrote:
> > On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr
> [...]
> > > Even though KJournald is currently contained in the "libraries" playground
> > > module, I would like
On Montag, 10. Oktober 2022 15:34:30 CEST Aleix Pol wrote:
> On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr
[...]
> > Even though KJournald is currently contained in the "libraries" playground
> > module, I would like to get it included in the "utilities" module after
> > passing KDE
On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr
wrote:
>
> Hi, after a few releases over the past year, I would like to get KJournald
> included in KDE application releases. This project is about providing both an
> QItemModel abstraction library for the C-style journald API and providing an
Neat!
- clazy has some hints
- you could probably use
https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html for
loggincategory.cpp/h?
- for qml you should probably use Kirigami.Units.gridUnit*N instead of
hardcoding sizes
- the hardcoded colors also seem a bit of an odd choice
- they
El diumenge, 9 d’octubre de 2022, a les 19:18:15 (CEST), Andreas Cord-Landwehr
va escriure:
> Hi, after a few releases over the past year, I would like to get KJournald
> included in KDE application releases. This project is about providing both
> an QItemModel abstraction library for the C-style
Hi, after a few releases over the past year, I would like to get KJournald
included in KDE application releases. This project is about providing both an
QItemModel abstraction library for the C-style journald API and providing an
efficient graphical browser for journald logs.
Sysadmins moved
12 matches
Mail list logo
