---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review18562
---
This review has been submitted with commit
On Aug. 12, 2012, 3:42 p.m., Maks Orlovich wrote:
kjs/jsonstringify.cpp, line 102
http://git.reviewboard.kde.org/r/105057/diff/5/?file=74786#file74786line102
Resetting m_state, m_rootIsUndefined here might be a good defensive
move (just in case stringify starts getting called
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/
---
(Updated Aug. 13, 2012, 5:36 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review17275
---
Ship it!
Almost there; will be OK iff everything below is
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review14245
---
kjs/jsonstringify.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review15376
---
kjs/jsonstringify.cpp
On July 4, 2012, 2:30 p.m., Maks Orlovich wrote:
kjs/jsonstringify.cpp, line 69
http://git.reviewboard.kde.org/r/105057/diff/2/?file=65648#file65648line69
Does this do the right thing if it's shorter than 10?
yes, it does
On July 4, 2012, 2:30 p.m., Maks Orlovich wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/
---
(Updated July 4, 2012, 10:27 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/
---
(Updated June 1, 2012, 1:30 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/
---
(Updated May 27, 2012, 3:25 p.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review14178
---
You forgot to change kjs/tests/ecmatest_broken_*
11 matches
Mail list logo