Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-21 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34805 --- Guys, thank you all very much for the thorough reviewing!

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34480 --- In addition to the issues below, I suspect it changes behavior

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34453 --- forgot to actually submit this yesterday... lets do it now

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34437 --- While speedup is certainly always great, this sounds dangerous

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Mark Gaiser
On June 16, 2013, 4:59 p.m., Sven Brauch wrote: While speedup is certainly always great, this sounds dangerous to me: I am getting an inconsistency. Using the unpatched fast mime detection on a file like: test.tar.gz gets detected as application-x-compressed-tar where the

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Sven Brauch
On June 16, 2013, 4:59 p.m., Sven Brauch wrote: While speedup is certainly always great, this sounds dangerous to me: I am getting an inconsistency. Using the unpatched fast mime detection on a file like: test.tar.gz gets detected as application-x-compressed-tar where the

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050/#review34443 --- Some comments on code. But I agree that this is too late for