Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 31, 2015, 10:24 vorm., Oswald Buddenhagen wrote: the description makes a good commit message, so please make sure you use that (apart from adding the BUG lines). Yes, of course. It's not my first commit to kde-workspace and I always handled it like that, i.e. using my

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121755/ --- (Updated Aug. 4, 2015, 5:53 p.m.) Status -- This change has been

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-31 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121755/#review83215 --- Ship it! the description makes a good commit message, so

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-30 Thread Wolfgang Bauer
On Juli 30, 2015, 12:05 nachm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-30 Thread Thomas Lübking
On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: This is Qt4, right? ::activateWindow() should be equivalent to XSetInputFocus(display, winId(), XRevertToParent, X11-time); unless a) _NET_ACTIVE_WINDOW is listed in _NET_SUPPORTED on the root window (supposed to be set and

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121755/#review83168 --- This is Qt4, right? ::activateWindow() should be equivalent