Re: Review Request: Adding Ångström to KUnitConversion

2011-03-23 Thread Etienne Rebetez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100923/ --- (Updated March 23, 2011, 8:32 p.m.) Review request for kdelibs. Changes

Re: Review Request: Adding Ångström to KUnitConversion

2011-03-23 Thread Ingo Klöcker
On March 23, 2011, 10:32 a.m., John Layt wrote: Weird, could have sworn I added Angstrom a while back. Anyway, just to add to the Dumb English vote for versions without the accents and the plural versions, we do this with other values as well. Wikipedia mentions something about

Re: Review Request: Adding Ångström to KUnitConversion

2011-03-22 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100923/#review2109 --- kunitconversion/length.cpp

Re: Review Request: Adding Ångström to KUnitConversion

2011-03-22 Thread Parker Coates
On March 22, 2011, 10:14 p.m., Parker Coates wrote: kunitconversion/length.cpp, line 146 http://git.reviewboard.kde.org/r/100923/diff/1/?file=12695#file12695line146 You missed Angstrom. Accents are too hard for some of us. :) Plural forms might be good too. Christoph Feck