On May 9, 2011, 7:37 p.m., David Palacio wrote:
kdialog/kdialog.cpp, line 366
http://git.reviewboard.kde.org/r/101282/diff/1/?file=15998#file15998line366
--icon is a KDE option.
Maybe that's why the first diff did not work?
I’ll try again using --icon KDE option
On May 9,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 10, 2011, 10:16 a.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3238
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3237
---
Ship it!
Thanks for looking at the issue and fixing it. If you
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 5, 2011, 3:57 p.m.)
Review request for KDE Base Apps.
On May 5, 2011, 8:36 p.m., Christoph Feck wrote:
kdialog/kdialog.cpp, line 378
http://git.reviewboard.kde.org/r/101282/diff/2/?file=16137#file16137line378
Could you add the icon argument to this fallback call, too? See API
docs for KPassivePopup.
Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3158
---
kdialog/kdialog.cpp
On May 6, 2011, 1:03 p.m., Christoph Feck wrote:
kdialog/kdialog.cpp, line 381
http://git.reviewboard.kde.org/r/101282/diff/4/?file=16242#file16242line381
Do not create a new KIconLoader, but use the global one.
The other issue is the hardcoded size. While the example
On May 5, 2011, 8:36 p.m., Christoph Feck wrote:
kdialog/kdialog.cpp, line 378
http://git.reviewboard.kde.org/r/101282/diff/2/?file=16137#file16137line378
Could you add the icon argument to this fallback call, too? See API
docs for KPassivePopup.
KPassivePopup requires a
On May 5, 2011, 8:36 p.m., Christoph Feck wrote:
kdialog/kdialog.cpp, line 100
http://git.reviewboard.kde.org/r/101282/diff/2/?file=16137#file16137line100
Bonus points if you change argument passing to const refs ;)
Oh, forgot about that (: Done
On May 5, 2011, 8:36 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 6, 2011, 12:16 p.m.)
Review request for KDE Base Apps.
On May 6, 2011, 1:03 p.m., Christoph Feck wrote:
kdialog/kdialog.cpp, line 381
http://git.reviewboard.kde.org/r/101282/diff/4/?file=16242#file16242line381
Do not create a new KIconLoader, but use the global one.
The other issue is the hardcoded size. While the example
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 6, 2011, 12:15 p.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 6, 2011, 2:52 p.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3143
---
kdialog/kdialog.cpp
15 matches
Mail list logo