On Nov. 17, 2011, 2:33 p.m., David Faure wrote:
David Faure wrote:
Cyril, can you rebase your changes on top of the kdelibs frameworks
branch, compile, and commit there?
Cyril Oblikov wrote:
Hi David.
I'm currently working on this dialog together with Björn
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/#review8269
---
- David Faure
On Aug. 24, 2011, 4:29 p.m., Cyril Oblikov
On Nov. 17, 2011, 2:33 p.m., David Faure wrote:
Cyril, can you rebase your changes on top of the kdelibs frameworks branch,
compile, and commit there?
- David
---
This is an automatically generated e-mail. To reply, visit:
On Nov. 17, 2011, 2:33 p.m., David Faure wrote:
David Faure wrote:
Cyril, can you rebase your changes on top of the kdelibs frameworks
branch, compile, and commit there?
Hi David.
I'm currently working on this dialog together with Björn Balazs. Now we a
mostly concentrated on the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/#review6699
---
I did not review the code, so I cannot comment on it. What I am
On Wednesday 24 August 2011 16:24:05 Cyril Oblikov wrote:
I wrote:
But did you at least run jobtest (in kdelibs/kio/tests) to make sure
that the new code doesn't break it? E.g. the creation of a dialog for sure
broke it, but now you've fixed that bit.
No, I didn't use tests. Are there
On Aug. 22, 2011, 4:06 p.m., David Faure wrote:
kio/kio/interactiondialog/allinteractionitem.h, line 47
http://git.reviewboard.kde.org/r/102388/diff/2/?file=32532#file32532line47
You can't use i18n in a header file, nor in a static object. Instead,
fill the list on demand when
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/
---
(Updated Aug. 24, 2011, 4:25 p.m.)
Review request for kdelibs and David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/
---
(Updated Aug. 24, 2011, 4:29 p.m.)
Review request for kdelibs and David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/
---
(Updated Aug. 22, 2011, 1:17 p.m.)
Review request for kdelibs and David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/#review5920
---
Nice job. Please find my comments below.
kio/kio/copyjob.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/
---
(Updated Aug. 22, 2011, 11:12 p.m.)
Review request for kdelibs and David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/
---
Review request for kdelibs.
Summary
---
Modeless dialog to handle
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/
---
(Updated Aug. 21, 2011, 3:21 p.m.)
Review request for kdelibs and David
14 matches
Mail list logo
