Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52381 --- I'm a bit lost with your latest patch uploaded... Speaking

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Dawit Alemayehu
On March 8, 2014, 12:40 p.m., Andrea Iacovitti wrote: I'm a bit lost with your latest patch uploaded... Speaking about the third patch in this review (Diff r3) it seems it works as expected. That is if a server redirects a collection DELETE operation to a new Location with trailing

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 8, 2014, 5:08 p.m.) Review request for kdelibs, Andrea

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52410 --- Ship it! Ah, yes. That is the fix. - Andrea Iacovitti On

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52413 --- This review has been submitted with commit

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 8, 2014, 9:42 p.m.) Status -- This change has been

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52294 --- I tested your patch, no trailing slash is added whether the

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Andrea Iacovitti
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: I tested your patch, no trailing slash is added whether the request refers to a collection or resource (as it was before commit 58294ac). Dawit Alemayehu wrote: Right, but now the webdav server should redirect to the right

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-06 Thread Dawit Alemayehu
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: I tested your patch, no trailing slash is added whether the request refers to a collection or resource (as it was before commit 58294ac). Dawit Alemayehu wrote: Right, but now the webdav server should redirect to the right

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 5, 2014, 2:01 p.m.) Review request for kdelibs, Andrea

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-04 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review51879 --- Still broken for webdav protocol (tested using konq/dolphin),

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-04 Thread Dawit Alemayehu
On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote: Still broken for webdav protocol (tested using konq/dolphin), can't delete file. isFile is always false whether you try to delete a file or folder so a trailing slash is always added. Well it works for me. I could not delete a

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-04 Thread Andrea Iacovitti
On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote: Still broken for webdav protocol (tested using konq/dolphin), can't delete file. isFile is always false whether you try to delete a file or folder so a trailing slash is always added. Dawit Alemayehu wrote: Well it works for

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-04 Thread Dawit Alemayehu
On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote: Still broken for webdav protocol (tested using konq/dolphin), can't delete file. isFile is always false whether you try to delete a file or folder so a trailing slash is always added. Dawit Alemayehu wrote: Well it works for

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 3, 2014, 3:50 p.m.) Review request for kdelibs, Andrea

Review Request 116122: Do not add trailing slash on http DELETE requests

2014-02-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- Review request for kdelibs, Andrea Iacovitti and David Faure. Bugs:

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-02-27 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review51064 --- What patch? ;) - Andrea Iacovitti On Feb. 27, 2014, 2:28