On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
lib/konq/src/konq_historyentry.h, line 57
https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
const ref, no?
Andrius da Costa Ribas wrote:
before I try to fix the pending issues: what are we going to
On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
lib/konq/src/konq_historyentry.h, line 57
https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
const ref, no?
Andrius da Costa Ribas wrote:
before I try to fix the pending issues: what are we going to
On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
lib/konq/src/konq_historyentry.h, line 57
https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
const ref, no?
Andrius da Costa Ribas wrote:
before I try to fix the pending issues: what are we going to
On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
lib/konq/src/konq_historyentry.h, line 57
https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
const ref, no?
before I try to fix the pending issues: what are we going to decide?
- Should we create
On Nov. 9, 2014, 9:52 p.m., Alexander Richardson wrote:
When I originally got KF5 to compile on windows I seem to remember having
to do this a few times manually as well.
Would it make sense to add the macro to KCoreAddons?
KDEPimLibs also depends on this macro in several places.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
---
lib/konq/src/konq_historyentry.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70149
---
Shouldn't it be actually implemented then?
- Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70152
---
When I originally got KF5 to compile on windows I seem to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/
---
Review request for KDE Base Apps, KDE Frameworks and kdewin.
Repository:
