Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-23 Thread Hugo Pereira Da Costa
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-22 Thread Harald Sitter
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-22 Thread Albert Astals Cid
On nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-22 Thread Harald Sitter
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-22 Thread Thomas Lübking
On Nov. 22, 2014, 12:18 vorm., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. Andrius da Costa Ribas wrote: generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/ --- (Updated Nov. 21, 2014, 10:47 p.m.) Status -- This change has been

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Andrius da Costa Ribas
On Nov. 22, 2014, 12:18 a.m., Harald Sitter wrote: This breaks the kde4 build as ECM is not being used there and generate_export_header is not available without ECM. generate_export_header isn't in ECM, but in cmake itself

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-21 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70761 --- This breaks the kde4 build as ECM is not being used there and

Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/ --- Review request for kde-workspace and kdewin. Repository: oxygen

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70122 --- liboxygen/CMakeLists.txt

Re: Review Request 121083: Replace manual export files with CMake's generate_export_header

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70150 --- Ship it! Other than that it should go in.