Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75358 --- startkde/kcminit/CMakeLists.txt

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75433 --- Can you explain why the count is different and why XCB's

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Feb. 4, 2015, 8:59 p.m.) Status -- This change has been

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Nick Shaforostoff
On Фев. 4, 2015, 9:16 д.п., Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6 you forgot to git add the config-xcb.h.cmake i know. its contents is the following: /* Define if you have XCB at

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-04 Thread Martin Gräßlin
On Feb. 4, 2015, 10:16 a.m., Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 6 https://git.reviewboard.kde.org/r/122320/diff/4/?file=346734#file346734line6 you forgot to git add the config-xcb.h.cmake Nick Shaforostoff wrote: i know. its contents is the

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
On Лют. 3, 2015, 7:08 до полудня, Martin Gräßlin wrote: components/CMakeLists.txt, line 2 https://git.reviewboard.kde.org/r/122320/diff/3/?file=346480#file346480line2 that seems unrelated change. sorry, i forgot to remove it -- i had to comment it because i had compile errors

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-03 Thread Nick Shaforostoff
On Лют. 3, 2015, 7:08 до полудня, Martin Gräßlin wrote: startkde/kcminit/CMakeLists.txt, line 16 https://git.reviewboard.kde.org/r/122320/diff/3/?file=346481#file346481line16 you find optional, but link required. OSX devs won't be happy with that change ;-) you need

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-02 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Feb. 2, 2015, 9:15 p.m.) Review request for kde-workspace,

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75256 --- components/CMakeLists.txt

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-02-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75184 --- startkde/kcminit/CMakeLists.txt

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-31 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75114 --- Looks ok from here. Martin may be able to tell whether

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-31 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- (Updated Jan. 31, 2015, 11:07 p.m.) Review request for kde-workspace,

Re: Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75061 --- startkde/kcminit/main.cpp

Review Request 122320: use xcb-screen count instead of qguiapplication.screens

2015-01-29 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/ --- Review request for kde-workspace, Martin Gräßlin and Thomas Lübking.