Re: ghostwriter is ready for your review

2023-02-05 Thread Kevin Kofler
Megan wrote: > It's definitely not supposed to look like that. I tried a fresh install > on my machine (removing and rebuilding from scratch) but could not > replicate the issue. It's supposed to be using Font Awesome's font > glyphs for the icons, since they are easily styled along with the

Re: ghostwriter is ready for your review

2022-11-01 Thread Carl Schwan
Le mardi 1 novembre 2022 à 11:27 AM, Albert Astals Cid a écrit : > El dijous, 13 d’octubre de 2022, a les 8:52:26 (CET), Megan va escriure: > > > Hello everyone, > > > > The /ghostwriter/ Markdown editor has finally hatched from its > > incubation and is ready for you to review at your

Re: ghostwriter is ready for your review

2022-11-01 Thread Albert Astals Cid
El dijous, 13 d’octubre de 2022, a les 8:52:26 (CET), Megan va escriure: > Hello everyone, > > The /ghostwriter/ Markdown editor has finally hatched from its > incubation and is ready for you to review at your convenience. > > Project repo: https://invent.kde.org/office/ghostwriter > > Project

Re: ghostwriter is ready for your review

2022-10-19 Thread Megan
Hi Christophe, It appears I made a very serious mistake listing the cmark-gfm license as AAL.  Unfortunately, that code's included COPYING file did not explicitly list the licenses, and I was guessing it was AAL.  The good news is that I was wrong.  It looks like it is BSD 2.  I have pushed

Re: ghostwriter is ready for your review

2022-10-18 Thread Megan
Using Qt for translations is fine acceptable. Doing a "major" rewrite after review kind of invalidates the review, and that's why I say that if you're going to rewrite it we should do the review later. Oh, I see.  I was under the impression that I had to eventually use ki18n.  As long as I

Re: ghostwriter is ready for your review

2022-10-18 Thread Christophe Giboudeaux
Hello, On jeudi 13 octobre 2022 08:52:26 CEST Megan wrote: > Hello everyone, > > The /ghostwriter/ Markdown editor has finally hatched from its > incubation and is ready for you to review at your convenience. > > Project repo: https://invent.kde.org/office/ghostwriter

Re: ghostwriter is ready for your review

2022-10-17 Thread Albert Astals Cid
El diumenge, 16 d’octubre de 2022, a les 5:05:40 (CEST), Megan va escriure: > Hi Albert, > > > If you're going to change something as core to an app as the i18n system I > > wouldn't say we're done for review stage yet. Or maybe you don't need to > > change it? > > Carl said it should be enough

Re: ghostwriter is ready for your review

2022-10-17 Thread Ingo Klöcker
On Sonntag, 16. Oktober 2022 05:05:40 CEST Megan wrote: > > You have 4 libs in the 3rdparty folder, is there any chance to use actual > > dependencies and not copied code? > > 1. Unfortunately, some of the dependencies aren't in every GNU/Linux > distribution. > 2. It is easier for doing Windows

Re: ghostwriter is ready for your review

2022-10-17 Thread Megan
Hi Albert, If you're going to change something as core to an app as the i18n system I wouldn't say we're done for review stage yet. Or maybe you don't need to change it? Carl said it should be enough to pass review with a Messages.sh and including ECMPoQmTools in the CMakeLists.txt file. 

Re: ghostwriter is ready for your review

2022-10-15 Thread Albert Astals Cid
El dijous, 13 d’octubre de 2022, a les 8:52:26 (CEST), Megan va escriure: > Hello everyone, > > The /ghostwriter/ Markdown editor has finally hatched from its > incubation and is ready for you to review at your convenience. > > Project repo: https://invent.kde.org/office/ghostwriter > > Project

ghostwriter is ready for your review

2022-10-15 Thread Megan
Hello everyone, The /ghostwriter/ Markdown editor has finally hatched from its incubation and is ready for you to review at your convenience. Project repo: https://invent.kde.org/office/ghostwriter Project website: https://ghostwriter.kde.org Note: ghostwriter currently uses QtLinguist for