Re: Review Request: Make the maximum # of connection per host in KIO::Scheduler user-configurable

2012-03-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104120/#review11139 --- Ship it! Looks good to me, thanks for this long-due fix. I

Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-03-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103699/#review11140 --- Looks ok to me, except for a few details. I presume you tested

Re: Review Request: Make the maximum # of connection per host in KIO::Scheduler user-configurable

2012-03-05 Thread Dawit Alemayehu
On March 5, 2012, 3:19 p.m., David Faure wrote: Looks good to me, thanks for this long-due fix. I don't know how well the underlying feature works (e.g. will the jobs wait for a connection or fail immediately, and will getConnectedSlave return 0 when the limit is reached) -- but

Re: Review Request: Make the maximum # of connection per host in KIO::Scheduler user-configurable

2012-03-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104120/ --- (Updated March 5, 2012, 3:46 p.m.) Review request for kdelibs and Andreas

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Lamarque Vieira Souza
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 14 http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line14 I didn't check, but how is INCLUDE_INSTALL_DIR set ? Is it done by via

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Lamarque Vieira Souza
On March 2, 2012, 6:57 p.m., Laszlo Papp wrote: I am a bit of layman in here (thus pardon me), but I would personally prefer a separated location for these config files. Something like either cmake/modules or in the experimental subfolder itself right next to the CTestConfig.cmake (I

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Alexander Neundorf
On March 5, 2012, 8:51 p.m., Alexander Neundorf wrote: experimental/libkdeclarative/KDeclarativeConfig.cmake.in, line 12 http://git.reviewboard.kde.org/r/104140/diff/1/?file=51648#file51648line12 You may want to use something like KDeclarative_SOURCE_DIR, which is defined if

Re: Review Request: Add cmake config for kdeclarative library.

2012-03-05 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/ --- (Updated March 5, 2012, 9:55 p.m.) Review request for kdelibs. Changes

Reactivate your KDE bugs.kde.org account before March 30th 2012

2012-03-05 Thread Tom Albers
Hi, We have recently installed a new update of the bugzilla software and we would like to ask you to reactivate your accounts. This can be done in one simple step: login on the http://bugs.kde.org site. If you don't reactivate your account before March 30th we will block your account from