Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32683 --- the point of notifications are, obviously, to inform the user.

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
On May 17, 2013, 7:33 a.m., Aaron J. Seigo wrote: the point of notifications are, obviously, to inform the user. if it hides as soon as something else is interacted with, the user will miss many (even most) notifications that appear while they are using the computer. obviously not

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 8:26 a.m.) Review request for kde-workspace and

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-17 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 17, 2013, 10:07 a.m.) Review request for kdelibs and Thiago

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-17 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 17, 2013, 10:08 a.m.) Review request for kdelibs and Thiago

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
On May 17, 2013, 7:33 a.m., Aaron J. Seigo wrote: the point of notifications are, obviously, to inform the user. if it hides as soon as something else is interacted with, the user will miss many (even most) notifications that appear while they are using the computer. obviously not

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32694 --- Ship it! this is fine by me then ... cheers. - Aaron J.

Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-05-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- Review request for kdelibs. Description --- This implemets a step in

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-05-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated May 17, 2013, 12:11 p.m.) Review request for kdelibs.

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
On May 17, 2013, 12:10 p.m., Aaron J. Seigo wrote: this is fine by me then ... cheers. Should it be backported to 4.10? - Romário --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32696 --- This review has been submitted with commit

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 12:57 p.m.) Status -- This change has been

Re: Review Request 110423: Searchprovider dialog: add insert query placeholder button

2013-05-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110423/#review32716 --- kurifilter-plugins/ikws/searchproviderdlg.cpp

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-05-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110328/#review32717 --- If there are no objections I intend to commit this patch early

Re: Review Request 110330: Make Prompt on access kwalletd setting apply in more situations

2013-05-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110330/#review32718 --- If there are no objections I intend to commit this patch early

Re: Review Request 110331: Sync kwalletmanager settings UI to kwalletd changes proposed in review 110330

2013-05-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110331/#review32719 --- If there are no objections I intend to commit this patch early