Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-11 Thread Kai Uwe Broulik
On May 9, 2011, 7:37 p.m., David Palacio wrote: kdialog/kdialog.cpp, line 366 http://git.reviewboard.kde.org/r/101282/diff/1/?file=15998#file15998line366 --icon is a KDE option. Maybe that's why the first diff did not work? I’ll try again using --icon KDE option On May 9,

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/ --- (Updated May 10, 2011, 10:16 a.m.) Review request for KDE Base Apps.

Re: Review Request: Enable kdialog to set an icon for passivepopup as well

2011-05-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101282/#review3238 --- This review has been submitted with commit

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3242 --- This review has been submitted with commit

Re: Userconfig: A KCModule for users and groups configuration

2011-05-11 Thread Nicolas Ternisien
Hi Romain, I'm Nicolas Ternisien, the quiet KDE Admin coordinator. That's a good news that userconfig tries to come back (again) to KDE Admin. Indeed, the last time we were pushing it, the fact it lacked LDAP support was the most problematic thing for replacing KUser. If it is planned, then we

Re: Qt5 - KDE5?

2011-05-11 Thread Boudewijn Rempt
On Monday 09 May 2011 May, Olivier Goffart wrote: - Do we want KDE 5 to be a big change, or just a small increment? Given that an app like krita has only just now reached enough maturity to reach an audience, any hint of big changes to the KDE platform make me really afraid. We (the krita

Re: Qt5 - KDE5?

2011-05-11 Thread Thiago Macieira
On Wednesday, 11 de May de 2011 08:03:25 Boudewijn Rempt wrote: On Monday 09 May 2011 May, Olivier Goffart wrote: - Do we want KDE 5 to be a big change, or just a small increment? Given that an app like krita has only just now reached enough maturity to reach an audience, any hint of big

Re: Review Request: New KLauncher DBus interface to check for on hold ioslave for a given url

2011-05-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101333/ --- (Updated May 11, 2011, 3:58 p.m.) Review request for kdelibs. Changes

Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101337/ --- Review request for kdelibs. Summary --- This patch changes the

Re: Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101337/#review3262 --- I don't know much about the code, just noticed a couple of

Re: Review Request: PATCH: Change the default KIO USERAGENT string.

2011-05-11 Thread Dawit Alemayehu
On May 11, 2011, 4:19 p.m., Alex Merry wrote: kio/kio/kprotocolmanager.cpp, line 350 http://git.reviewboard.kde.org/r/101337/diff/1/?file=16340#file16340line350 Wouldn't asyncCall be better, since we don't care about the reply? Or just pass QDBus::NoBlock to call(). Currently

Re: Review Request: New KLauncher DBus interface to check for on hold ioslave for a given url

2011-05-11 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101333/#review3264 --- Ship it! Looks good. Lots of monkey work to get a small

Re: Qt5 - KDE5?

2011-05-11 Thread Marco Martin
On Tuesday 10 May 2011, Alex Merry wrote: On 10/05/11 09:26, Aaron J. Seigo wrote: we also have some blighted API that remains that needs cleaning up, but we also need to exercise restraint. since we don't need to make huge changes to many parts of Platform, we should try and show caution

Re: Qt5 - KDE5?

2011-05-11 Thread Marco Martin
On Wednesday 11 May 2011, Thiago Macieira wrote: On Wednesday, 11 de May de 2011 08:03:25 Boudewijn Rempt wrote: On Monday 09 May 2011 May, Olivier Goffart wrote: - Do we want KDE 5 to be a big change, or just a small increment? Given that an app like krita has only just now reached

Re: Review Request: New KLauncher DBus interface to check for on hold ioslave for a given url

2011-05-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101333/#review3265 --- This review has been submitted with commit

Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves

2011-05-11 Thread Friedrich W. H. Kossebau
Hi Nikhil, you know that today, April 12th, is already Hard Feature Freeze?! Would be really sad if your upnp-ms kio-slave misses the deadline now! Mardi, le 26 avril 2011, à 14:53, Nikhil Marathe a écrit: Hi, KDE SC 4.7 soft feature freeze is close, and I would like to propose the UPnP

Re: Upcoming freezes KDE 4.7

2011-05-11 Thread John Layt
On Tuesday 10 May 2011 23:39:37 Dawit A wrote: I will try to inform the translators by marking my commits with GUI: and also sending a message about the changes to the appropriate list. Once the soft freeze arrives you must first get permission from the kde-i18n- doc mailing list _before_ you

Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves

2011-05-11 Thread Nikhil Marathe
On Wed, May 11, 2011 at 4:04 PM, Friedrich W. H. Kossebau kosse...@kde.org wrote: Hi Nikhil, you know that today, April 12th, is already Hard Feature Freeze?! Would be really sad if your upnp-ms kio-slave misses the deadline now! Hi Fredrik, I have been moving halfway across the world the