Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 15, 2012, 10:15 p.m.) Review request for kdelibs and David

Review Request: Activities support for Konqueror

2012-10-16 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- Review request for KDE Base Apps. Description --- Konqueror reports

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20450 --- kio/kio/kfileitem.cpp

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review20451 --- kioslave/ftp/ftp.cpp

Review Request: Let kio_smb store passwords in KWallet again.

2012-10-16 Thread Gordian Klein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106909/ --- Review request for KDE Runtime. Description --- Hi, this patch fixes

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 16, 2012, 2:43 p.m.) Review request for kdelibs and David

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 16, 2012, 4:15 p.m.) Review request for kdelibs and David

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20459 --- kio/kio/kfileitem.cpp

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
On Oct. 16, 2012, 3:39 p.m., David Faure wrote: kio/kio/kfileitem.cpp, line 515 http://git.reviewboard.kde.org/r/106902/diff/4/?file=90765#file90765line515 kdelibs coding style says this should be on the same line as the if(). The whole file has braces on new line, so to be

KDE Build CI and kdepimlibs

2012-10-16 Thread Ben Cooksley
Hi all, Today the primary build slave behind build.kde.org ran out of disk space, due to 330gb of Akonadi test (part of kdepimlibs) debris which had accumulated and eaten up disk space. To prevent this from recurring again, and to ensure that kdepimlibs does not overly occupy the resources of

Re: Review Request: Let kio_smb store passwords in KWallet again.

2012-10-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106909/#review20474 --- Ship it! Looks good to me, specially since it is I that added