Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/#review29173 --- Looks good, please fix the one issue below and commit.

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/#review29177 --- Ship it! As I said, ship it :-) - David Faure On March 14,

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/#review29178 --- This review has been submitted with commit

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/ --- (Updated March 14, 2013, 9:29 a.m.) Status -- This change has been

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

2013-03-14 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/#review29158 --- One thing which came to my mind while I further worked on

Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/ --- Review request for kdelibs and David Faure. Description --- This

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread Raymond Wooninck
On March 14, 2013, 8:36 a.m., David Faure wrote: khtml/imload/decoders/gifloader.cpp, line 361 http://git.reviewboard.kde.org/r/109478/diff/1/?file=119702#file119702line361 What's e ? an error code? Please rename the variable then, for more readability. Indeed an error code,

Re: Review Request 109478: Make kdelibs compile with the latest giflib (v5)

2013-03-14 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109478/ --- (Updated March 14, 2013, 9:14 a.m.) Review request for kdelibs and David

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

2013-03-14 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/#review29212 --- Ship it! Looks good to me. I would think the default

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

2013-03-14 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/#review29215 --- Yeah, but don't push to kdelibs master, push to KDE/4.10

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

2013-03-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/#review29217 --- This review has been submitted with commit

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

2013-03-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/ --- (Updated March 14, 2013, 5:10 p.m.) Status -- This change has been

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

2013-03-14 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109421/ --- (Updated March 14, 2013, 3:24 p.m.) Review request for kdelibs and Jeremy