Review Request 113183: Code cleanup - remove unused label

2013-10-10 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113183/ --- Review request for kdelibs. Repository: kdelibs Description ---

Review Request 113184: windowmanagement: Remove unused variable

2013-10-10 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113184/ --- Review request for kdelibs. Repository: kdelibs Description ---

Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/ --- Review request for kde-workspace, kwin, Fredrik Höglund, and Thomas

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/ --- (Updated Oct. 10, 2013, 11:51 a.m.) Review request for kde-workspace,

Re: Review Request 105304: Allow usage of detailedsorry and detailederror in kdialog

2013-10-10 Thread Albert Astals Cid
On July 12, 2012, 4:17 p.m., David Faure wrote: Looks good. For master only, though, given feature+message freeze in 4.9. Kai Uwe Broulik wrote: Totally forgot to commit this :( Will do for master (4.10) once my ssh key for my new notebook got imported. Albert Astals Cid wrote:

Re: Review Request 103638: #include fixx11h.h

2013-10-10 Thread Erik Sigra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103638/ --- (Updated Oct. 10, 2013, 10:04 a.m.) Status -- This change has been

Re: Review Request 110108: Missing response for Authentication failure in kdepasswd

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110108/#review41479 --- This review has been submitted with commit

Re: Review Request 110108: Missing response for Authentication failure in kdepasswd

2013-10-10 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110108/ --- (Updated Oct. 10, 2013, 10:13 a.m.) Status -- This change has been

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to )

2013-10-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/#review41480 --- Was this commited? Also isn't a whole remove in the middle a

Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget

2013-10-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/ --- Review request for kdelibs and David Faure. Bugs: 324879

Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-10 Thread Jiří Pinkava
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113189/ --- Review request for kdelibs. Repository: kdelibs Description ---

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/#review41483 --- Ship it! Ship It! - Christoph Feck On Oct. 10, 2013, 9:51

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/#review41484 --- https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right,

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Thomas Lübking
On Oct. 10, 2013, 11:04 a.m., Christoph Feck wrote: Ship It! Please hold it. - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113185/#review41483

Re: Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113189/#review41486 --- Same patch is being submitted into the frameworks branch, see

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Wolfgang Bauer
On Oct. 10, 2013, 1:21 p.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Thomas Lübking
On Oct. 10, 2013, 11:21 a.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-10 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113189/#review41489 --- This is a bit confussing... lets sum up the background story:

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Wolfgang Bauer
On Oct. 10, 2013, 1:21 p.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to )

2013-10-10 Thread Ömer Fadıl Usta
On Oct. 10, 2013, 1:16 p.m., Albert Astals Cid wrote: Was this commited? Also isn't a whole remove in the middle a bit too dangerous? I had also some suspicions so i delayed commiting for check it on different installed paths on the other hand i forget to commit. so it didn't committed

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Thomas Lübking
On Oct. 10, 2013, 11:21 a.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to )

2013-10-10 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/ --- (Updated Oct. 10, 2013, 12:28 p.m.) Status -- This change has been

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to )

2013-10-10 Thread Aaron J. Seigo
On Oct. 10, 2013, 10:16 a.m., Albert Astals Cid wrote: Was this commited? Also isn't a whole remove in the middle a bit too dangerous? Ömer Fadıl Usta wrote: I had also some suspicions so i delayed commiting for check it on different installed paths on the other hand i forget

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Wolfgang Bauer
On Oct. 10, 2013, 1:21 p.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Thomas Lübking
On Oct. 10, 2013, 11:21 a.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to )

2013-10-10 Thread Albert Astals Cid
On Oct. 10, 2013, 10:16 a.m., Albert Astals Cid wrote: Was this commited? Also isn't a whole remove in the middle a bit too dangerous? Ömer Fadıl Usta wrote: I had also some suspicions so i delayed commiting for check it on different installed paths on the other hand i forget

Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes without a file called size_fdiag

2013-10-10 Thread Wolfgang Bauer
On Oct. 10, 2013, 1:21 p.m., Thomas Lübking wrote: https://bugs.kde.org/show_bug.cgi?id=54359 If Fredrik's right, the tutorial used by most cursor creators would be wrong (great...) I guess to be absolutely sure, we'll have to XCreateFontCursor and then somehow get the bitmaps

Re: Packaging KDE Foundation 5 frameworks

2013-10-10 Thread Milian Wolff
On Wednesday 09 October 2013 19:26:48 Alexander Neundorf wrote: On Wednesday 09 October 2013, Lubomir Rintel wrote: Hi, I know it's a bit too early, but still better than late. I'd like to know your thoughts about the way KF5 frameworks will be packaged for Linux distributions.

Re: Packaging KDE Foundation 5 frameworks

2013-10-10 Thread Alexander Neundorf
On Thursday 10 October 2013, Milian Wolff wrote: On Wednesday 09 October 2013 19:26:48 Alexander Neundorf wrote: On Wednesday 09 October 2013, Lubomir Rintel wrote: Hi, I know it's a bit too early, but still better than late. I'd like to know your thoughts about the way KF5

Re: Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-10 Thread Michael Pyne
On Oct. 10, 2013, 11:59 a.m., Bernd Buschinski wrote: This is a bit confussing... lets sum up the background story: - kjs(/wtf) loves gcc features - kjs-cmake filters out (gcc) pedantic now comes the problem... whats with other compilers? if you look at the commit message

Review Request 113194: port away from KIcon in libs/taskmanager

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113194/ --- Review request for kde-workspace. Repository: kde-workspace Description

Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

2013-10-10 Thread Bruno Farias
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112848/ --- (Updated Oct. 10, 2013, 6:36 p.m.) Review request for kdelibs. Changes

Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

2013-10-10 Thread Bruno Farias
On Oct. 5, 2013, 5:17 a.m., David Faure wrote: One thing I just noticed -- KButtonGroup is deprecated in KF5, in favour of QGroupBox + QButtonGroup. So while this is certainly good to go in, you might want to use QGroupBox+QButtonGroup in your code instead... Shall I commit it

Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

2013-10-10 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113196/ --- Review request for kdelibs. Repository: kdelibs Description ---