Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) Diffs - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- Review request for kdelibs, Christoph Feck and Ian Wadham. Bugs: 337356 http://bugs.kde.org/show_bug.cgi?id=337356 Repository: kdelibs Description --- This bundles both patches submitted by René J.V. Bertin in the associated issue Diffs - kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 Diff: https://git.reviewboard.kde.org/r/119243/diff/ Testing --- See issue for more info from René. --- I myself haven't yet tested this. Will report back as soon as I got to it. Thanks, Marko Käning
Re: Downtime notification
Hi, The server has been migrated and bugs.kde.org is now up and running. Maybe you could find it not available for a short time until DNS gets updated. Thanks, Víctor Blázquez Víctor Blázquez On Thu, Jul 10, 2014 at 11:39 PM, Ben Cooksley bcooks...@kde.org wrote: Hi all, To allow for a server move and software upgrade, bugs.kde.org will not be accessible from 18:00 UTC on Friday 11th July. Apologies for any inconvenience. As this will involve a DNS change, you may not be able to access Bugzilla if your DNS has not updated following the server move. Thanks, Ben Cooksley KDE Sysadmin
Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62175 --- Just out of curiosity, but why would KIO need to know the platform at all? I mean, on linux (kde) we have the platformintegration stuff that modifies the default dialogs to our liking. On Mac and Windows the defaults of Qt should already integrate with the platform so i don't really see why KIO would need any platform knowledge in this regard. Just open a default dialog and be done with it, no? Sorry if i'm totally wrong since i don't know this code. In that case, please do elaborate on why KIO works the way it does. - Mark Gaiser On July 12, 2014, 9:55 a.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 12, 2014, 9:55 a.m.) Review request for kdelibs, Christoph Feck and Ian Wadham. Bugs: 337356 http://bugs.kde.org/show_bug.cgi?id=337356 Repository: kdelibs Description --- This bundles both patches submitted by René J.V. Bertin in the associated issue Diffs - kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 Diff: https://git.reviewboard.kde.org/r/119243/diff/ Testing --- See issue for more info from René. --- I myself haven't yet tested this. Will report back as soon as I got to it. Thanks, Marko Käning
Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Июль 12, 2014, 5:12 п.п.) Review request for kde-workspace, Plasma and Hui Ni. Changes --- As a last resort for the patch to be reviewed, adding nihui@ to reviewers, who committed to the ibus-panel last times. Repository: kimtoy Description --- The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used. This happens due to the following reasons: 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time This patch resolves both issues and makes ibus-panel compile on OpenBSD. (I found no suitable review group and therefore used plasma instead, as it was in plasma-addons previously; please, feel free to correct me if I'm wrong and sorry for any possible inconvenience) ((as there was no feedback for more than a week, I've added kde-workspace group to list of reviewers, too)) Diffs - cmake/FindIBus.cmake 8250c49 ibus-panel/CMakeLists.txt 3a1ee49 Diff: https://git.reviewboard.kde.org/r/119025/diff/ Testing --- OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the code is same) Thanks, Vadim Zhukov
Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62184 --- kio/kfile/kfiledialog.cpp https://git.reviewboard.kde.org/r/119243/#comment43221 I don't know why you did that, but it doesn't look good. Other than that it looks ok. Please update the patch though. - Aleix Pol Gonzalez On July 12, 2014, 9:55 a.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 12, 2014, 9:55 a.m.) Review request for kdelibs, Christoph Feck and Ian Wadham. Bugs: 337356 http://bugs.kde.org/show_bug.cgi?id=337356 Repository: kdelibs Description --- This bundles both patches submitted by René J.V. Bertin in the associated issue Diffs - kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 Diff: https://git.reviewboard.kde.org/r/119243/diff/ Testing --- See issue for more info from René. --- I myself haven't yet tested this. Will report back as soon as I got to it. Thanks, Marko Käning
Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 4:22 p.m.) Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) Diffs (updated) - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62192 --- Which branch should that go in? I do not know what is currently a release branch. It should probably also be forward ported to frameworks even if the Mac part is currently not compiled (hint: if someone adjusts the code it could be included again ;-) ). kdeui/windowmanagement/kwindowinfo_mac.cpp https://git.reviewboard.kde.org/r/119240/#comment43224 what's the RJVB 20140706 standing for? - Martin Gräßlin On July 12, 2014, 4:22 p.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 4:22 p.m.) Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) Diffs - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
On July 12, 2014, 6:01 p.m., Martin Gräßlin wrote: Which branch should that go in? I do not know what is currently a release branch. It should probably also be forward ported to frameworks even if the Mac part is currently not compiled (hint: if someone adjusts the code it could be included again ;-) ). I do not know where fixes like this should go to. This patch is based on master. On July 12, 2014, 6:01 p.m., Martin Gräßlin wrote: kdeui/windowmanagement/kwindowinfo_mac.cpp, line 54 https://git.reviewboard.kde.org/r/119240/diff/2/?file=289759#file289759line54 what's the RJVB 20140706 standing for? That's René's original comment. It will be taken out once this is ready for commit, since credit will be given by the commit message then. :) - Marko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62192 --- On July 12, 2014, 4:22 p.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 4:22 p.m.) Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) Diffs - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 7:02 p.m.) Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Changes --- Add RVJB's link to Apple's documentation Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description (updated) --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) See also this: https://developer.apple.com/library/mac/documentation/CoreFoundation/Reference/CFTypeRef/Reference/reference.html#//apple_ref/c/func/CFRelease Diffs - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Re: 4.13.3 tarballs are available for packagers
On Sat, Jul 12, 2014 at 5:28 PM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 12 de juliol de 2014, a les 17:24:30, Albert Astals Cid va escriure: Note that baloo unit tests are not passing and if it's not fixed (+ package respun) before tuesday it won't be part of the release. I mean http://build.kde.org/view/KDE%20SC%20stable/job/baloo_stable/ is not green. I'm really not sure why the test is failing. It is passing perfectly on multiple machines that I've tried it out. It just seems to be jenkins. I'll try to figure it out, otherwise I'll disable the test. I specially wrote the test when I was fixing a bug for 4.13.3. Cheers, Albert Cheers, Albert El Divendres, 11 de juliol de 2014, a les 20:40:05, Torgny Nyblom va escriure: Hi, tarballs for KDE SC 4.13.3 and kde-workspace 4.11.11 are available at the usual location. /Regards Torgny Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62201 --- Ship it! Seems clear enough. In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp - David Faure On July 12, 2014, 6:17 p.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 6:17 p.m.) Review request for kdelibs, David Faure, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) for Qt4! (Unclear is atm where this would have to be fixed in KF5.) See also this: https://developer.apple.com/library/mac/documentation/CoreFoundation/Reference/CFTypeRef/Reference/reference.html#//apple_ref/c/func/CFRelease Diffs - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX
On July 12, 2014, 6:49 p.m., David Faure wrote: Seems clear enough. In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp Marko Käning wrote: Thanks for the info about KF5! Which branch should this be committed to on kdelibs4? Simply on master or also on (an)other branch(es)? Commit to KDE/4.13, and merge (or ask someone to merge) to KDE/4.14 and master. [Or if you don't care for the 4.13 branch on mac, commit to KDE/4.14 directly and merge to master.] - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62201 --- On July 12, 2014, 6:17 p.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 6:17 p.m.) Review request for kdelibs, David Faure, Martin Gräßlin, Ian Wadham, and Thomas Lübking. Bugs: 337154 http://bugs.kde.org/show_bug.cgi?id=337154 Repository: kdelibs Description --- Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) for Qt4! (Unclear is atm where this would have to be fixed in KF5.) See also this: https://developer.apple.com/library/mac/documentation/CoreFoundation/Reference/CFTypeRef/Reference/reference.html#//apple_ref/c/func/CFRelease Diffs - kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 Diff: https://git.reviewboard.kde.org/r/119240/diff/ Testing --- For more details see associated bug Thanks, Marko Käning
Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar
On July 12, 2014, 10:08 a.m., Marko Käning wrote: It seems to me there should be a config item UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But what is that file's name and where is it usually located in the Linux/KDE directory trees? And how could a user get to select whether that item is true or false on his or her desktop? I have just spent an hour or two searching, hindered by not knowing the name of the needle and also by not knowing which haystack to search. Apple and MacPorts have their own ways of squirelling things away. On July 12, 2014, 10:08 a.m., Marko Käning wrote: kdeui/widgets/kmainwindow.cpp, line 244 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289738#file289738line244 Actually, I don't know whether I want this integration as default... I have tested this on my Mac OS X kdesrc-build setup. It works OK, BUT loses the KDE functionality of being able to right-click on a toolbar and select icon-size, text-position and text-visibility. The general effect is that you have one big rounded-looking bar, rather than two bars with a crease between them. Also, strongly-colored icons seem to get dimmed out more by surrounding dark-grayness when the combined-bar window is selected than when there are two separate bars. Therefore I think we should avoid this one, even if it does look cool. - Ian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62168 --- On July 12, 2014, 9:55 a.m., Marko Käning wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- (Updated July 12, 2014, 9:55 a.m.) Review request for kdelibs, Christoph Feck and Ian Wadham. Bugs: 337356 http://bugs.kde.org/show_bug.cgi?id=337356 Repository: kdelibs Description --- This bundles both patches submitted by René J.V. Bertin in the associated issue Diffs - kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 Diff: https://git.reviewboard.kde.org/r/119243/diff/ Testing --- See issue for more info from René. --- I myself haven't yet tested this. Will report back as soon as I got to it. Thanks, Marko Käning
