> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your
> > change, but the test passed nevertheless.
>
> Martin Gräßlin wrote:
> ah now I see. You adjusted the test application, but not the autotest.
>
> Jonathan
> On May 17, 2016, 3:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your
> > change, but the test passed nevertheless.
>
> Martin Gräßlin wrote:
> ah now I see. You adjusted the test application, but not the autotest.
Now I see that
> On May 17, 2016, 4:29 p.m., Martin Gräßlin wrote:
> > The test does not verify the problem. I just pulled the patch, undid your
> > change, but the test passed nevertheless.
ah now I see. You adjusted the test application, but not the autotest.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95535
---
The test does not verify the problem. I just pulled the
> On May 17, 2016, 2:35 p.m., Martin Gräßlin wrote:
> > The change looks sensible to me, but I would appreciate a test case for it.
> > There are already some tests for the file dialog, so it should be easy to
> > extend.
There is no autotest, but have updated tests/qfiledialogtest with
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---
(Updated May 17, 2016, 3:20 p.m.)
Review request for kde-workspace and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/#review95532
---
The change looks sensible to me, but I would appreciate a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
---
Review request for kde-workspace and Plasma.
Bugs: 360666
Hi,
Users with the latest plasma/frameworks who build Krita themselves
are reporting that the file dialog no longer warns about overwriting
existing files:
https://bugs.kde.org/show_bug.cgi?id=360666
I'm not sure what's going on here, the warning correctly appears
with the GTK file dialog, the