Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2016-09-22 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/#review99471 --- Closing as this review request is more than 2 years old. If

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/#review99455 --- Closing as this review request is more than 2 years old. If

Re: Review Request 128909: initial, minimal support for OS X

2016-09-22 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/ --- (Updated Sept. 22, 2016, 9:25 p.m.) Review request for KDE Base Apps and

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/ --- (Updated Sept. 22, 2016, 7:24 p.m.) Status -- This change has been

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
> On sep. 22, 2016, 8:53 après-midi, David Edmundson wrote: > > Do you have commit access? No I don't. - Pascal --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427 --- Ship it! Do you have commit access? - David Edmundson

Re: Review Request 128909: initial, minimal support for OS X

2016-09-22 Thread René J . V . Bertin
> On Sept. 22, 2016, 6:05 p.m., Aleix Pol Gonzalez wrote: > > processui/ReniceDlg.cpp, line 79 > > > > > > Wrong indentation. > > Also isn't it possible to query the backend or something? Wrong indentation

Re: Review Request 128909: initial, minimal support for OS X

2016-09-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/#review99424 --- processui/ReniceDlg.cpp (lines 56 - 57)

Re: Review Request 128909: initial, minimal support for OS X

2016-09-22 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128909/ --- (Updated Sept. 22, 2016, 4:50 p.m.) Review request for KDE Base Apps and

Re: Review Request 128909: initial, minimal support for OS X

2016-09-22 Thread René J . V . Bertin
> On Sept. 17, 2016, 9:52 p.m., René J.V. Bertin wrote: > > processui/ReniceDlg.cpp, lines 78-87 > > > > > > I've actually managed to get ksysguardprocesslist_helper to work with a > > patched libdbus and a hack

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/ --- (Updated sep. 22, 2016, 4:01 après-midi) Review request for