Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
> On 九月 16, 2017, 9:19 a.m., Albert Astals Cid wrote: > > Are you sure this fixes anything? > > > > Just before the lines you changed we have > > > > > > if ( ! buttonTbl->item(number, 0) ) > > buttonTbl->setItem(number, 0, new QTableWidgetItem()); > > > > Which will create the

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
> On 九月 16, 2017, 9:19 a.m., Albert Astals Cid wrote: > > Are you sure this fixes anything? > > > > Just before the lines you changed we have > > > > > > if ( ! buttonTbl->item(number, 0) ) > > buttonTbl->setItem(number, 0, new QTableWidgetItem()); > > > > Which will create the

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread Albert Astals Cid
> On set. 16, 2017, 9:19 a.m., Albert Astals Cid wrote: > > Are you sure this fixes anything? > > > > Just before the lines you changed we have > > > > > > if ( ! buttonTbl->item(number, 0) ) > > buttonTbl->setItem(number, 0, new QTableWidgetItem()); > > > > Which will create the

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
> On 九月 16, 2017, 9:19 a.m., Albert Astals Cid wrote: > > Are you sure this fixes anything? > > > > Just before the lines you changed we have > > > > > > if ( ! buttonTbl->item(number, 0) ) > > buttonTbl->setItem(number, 0, new QTableWidgetItem()); > > > > Which will create the

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/#review103704 --- Are you sure this fixes anything? Just before the lines

Re: Review Request 130245: Fix Crash on JoyStick Config when js device did not contain regular joystick button

2017-09-16 Thread TOM Harrison via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/ --- (Updated 九月 16, 2017, 7:07 a.m.) Review request for kde-workspace.