Re: Review Request 130239: Exclude kconf_update from catching by uac on Windows

2017-10-06 Thread Ralf Habacker
> On Sept. 26, 2017, 8:02 p.m., Albert Astals Cid wrote: > > cmake/modules/Win32Macros.cmake > > Lines 61 (patched) > > > > > > I don't think it makes sense adding a new public-ish macro in 4.14.lots > > Ralf

Re: Latte Dock in review phase

2017-10-06 Thread Adriaan de Groot
On Friday, 6 October 2017 09:47:26 CEST Jonathan Riddell wrote: > Looks good from a brief look around I did from a packagers point of > view (so not looking at the code). The licensing is a funky (not bad, just .. unusual) mix of LGPL v2+ and GPL v2+; for instance app/ contains 7 files licensed

Re: Latte Dock in review phase

2017-10-06 Thread Jonathan Riddell
Looks good from a brief look around I did from a packagers point of view (so not looking at the code). I'm unsure why it's both a plasmoid and a standalone binary, that seems superfluous. Maybe it's for use outwith Plasma. docs/ directory seems unused Green build in neon :)

Latte Dock in review phase

2017-10-06 Thread Michail Vourlakos
Hello everyone, we decided to make Latte an active kde project and so now it is in review phase. I believe the best place to be is extragear because we would like to keep some independence for the first year concerning releases... What is Latte Dock? Latte is a project that is trying to provide