Re: Koko in KDEReview

2021-03-16 Thread Adriaan de Groot
On Tuesday, 16 March 2021 20:10:46 CET Carl Schwan wrote: > > > - on the topic of licensing: since the code base is really close to > > > complete reuse coverage it might be nice to push it over the finishing > > > line and then `reuse lint` it to not have it fall behind again > > This will be

Re: Koko in KDEReview

2021-03-16 Thread Carl Schwan
Le dimanche, mars 14, 2021 1:03 AM, Carl Schwan a écrit : > Le dimanche, mars 14, 2021 12:22 AM, Albert Astals Cid aa...@kde.org a écrit : > > > El dissabte, 13 de març de 2021, a les 20:14:26 CET, Carl Schwan va > > escriure: > > > > > Hi, > > > I would like to move Koko to KDEReview. Koko is

Re: Koko in KDEReview

2021-03-16 Thread Carl Schwan
Le mardi, mars 16, 2021 12:55 PM, Harald Sitter a écrit : > On Tue, Mar 16, 2021 at 12:49 PM Harald Sitter sit...@kde.org wrote: > > > Yay! Thanks for the big review :) > > > > - please get a bugzilla produce created for it Not a fan of that. This will ends up exactly like the www bugs,

Re: Koko in KDEReview

2021-03-16 Thread Harald Sitter
On Tue, Mar 16, 2021 at 12:49 PM Harald Sitter wrote: > > Yay! > > - please get a bugzilla produce created for it > - COPYING-CMAKE-SCRIPTS seems unused > - the find_package calls on qt5 probably should be versioned on > whatever version you actually tested with, currently it's unversioned >

Re: Koko in KDEReview

2021-03-16 Thread Harald Sitter
Yay! - please get a bugzilla produce created for it - COPYING-CMAKE-SCRIPTS seems unused - the find_package calls on qt5 probably should be versioned on whatever version you actually tested with, currently it's unversioned which I doubt is correct - same for kquickimageeditor - kquickimageeditor